Stop buffer calls start buffer

[d-scanzi]

Hi there,

I was looking at the stop_buffer function in SMITE_ET and noticed a couple of things I do not fully understand. The function is defined as:

def stop_buffer(self, clear_buffer=False):
    ''' Stop recording data into buffer
    '''
    self.rawSMI.start_buffer()   

Should not this function call self.rawSMI.stop_buffer()? Furthermore, the clear_buffer argument looks like is not used, or am I missing something?

Thank you for your work!

Have a great day,

Daniele

[marcus-nystrom]

Hi Daniele,

That indeed looks like an error. I have fixed and committed the update.

Thanks, Marcus

On Thu, Oct 6, 2022 at 3:39 AM d-scanzi @.***> wrote:

Hi there,

I was looking at the stop_buffer function in SMITE_ET and noticed a couple of things I do not fully understand. The function is defined as:

def stop_buffer(self, clear_buffer=False): ''' Stop recording data into buffer ''' self.rawSMI.start_buffer()

Should not this function call self.rawSMI.stop_buffer()? Furthermore, the clear_buffer argument looks like is not used, or am I missing something?

Thank you for your work!

Have a great day,

Daniele

— Reply to this email directly, view it on GitHub https://github.com/marcus-nystrom/SMITE/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD57FB5LX5II2PC5WM42ZTTWBYUWRANCNFSM6AAAAAAQ6CO3U4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>