search

marcus-sonestedt / t13activityweb

Website to help organizations & clubs coordinate activities amongst their members
GNU Affero General Public License v3.0
2 stars 1 forks source link

Fix for ie #57

Closed spdavid closed 4 years ago

spdavid commented 4 years ago

This should fix IE. Needs to be tested with a full build. target had to be downgraded to es5. and I modified the code a bit on the index.html. Plus added the pollyfills for IE.

Option 2.. Scrap this and tell people to use chrome or any other modern browser.

marcus-sonestedt commented 4 years ago

I manually deployed this to the to test site.

Got this in IE, "ReferenceError: 'AbortController' is undefined". Chrome works.

I actually planned to just have the site detect IE and say "please use a modern browser", rather than a bunch of errors. Given that we have some IE support now, adding that might not be too hard, or?

spdavid commented 4 years ago

I added a pollyfill for abort controller.. Might do the trick. cant know for sure unless its a production build.

In my opinion we should show the message.. "User Modern Browser". I can fix that.

marcus-sonestedt commented 4 years ago

Sounds good. Add that message instead.

Den sön 10 maj 2020 kl 23:14 skrev David Opdendries < notifications@github.com>:

I added a pollyfill for abort controller.. Might do the trick. cant know for sure unless its a production build.

In my opinion we should show the message.. "User Modern Browser". I can fix that.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/marcusl/t13activityweb/pull/57#issuecomment-626390692, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAKTYAJB74EFNZ5NM2JOITRQ4KLZANCNFSM4M3VXL3Q .

marcus-sonestedt commented 4 years ago

Closing this then. Waiting for new PR on message.