marcus905 / libnfc

Automatically exported from code.google.com/p/libnfc
GNU Lesser General Public License v3.0
0 stars 0 forks source link

Copyright notices would require some cleaning... #226

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Copyright notices, authors & dates are a bit outdated and modley.
Some cleaning would be welcome :-)

Original issue reported on code.google.com by yob...@gmail.com on 31 Jan 2013 at 9:44

GoogleCodeExporter commented 9 years ago
Could you be more precise ?

Original comment by romu...@libnfc.org on 16 Feb 2013 at 2:31

GoogleCodeExporter commented 9 years ago
Copyright date in files headers was not updated most of the time when the file 
was edited for the last time.

Copyright authors list in files headers was not updated most of the time when a 
new author contributed.

Does it make sense to try to keep separate dates & author lists in each file?

Wouldn't be easier to have the same generic header in each file and a proper 
author list in AUTHORS file?

Original comment by yob...@gmail.com on 16 Feb 2013 at 4:20

GoogleCodeExporter commented 9 years ago
http://www.gnu.org/prep/maintain/html_node/Copyright-Notices.html

Original comment by romuald.conty on 10 Mar 2013 at 10:59

GoogleCodeExporter commented 9 years ago
Proposal:

Copyright years are set same across all files, according to the above link.

AUTHORS lists *all* contributors.

Individuals files have a standard header, possibly completed by extra 
contributors if the current file contains their name, something like this:

 * Public platform independent Near Field Communication (NFC) library
 *
 * Libnfc historical contributors:
 * Copyright (C) 2009      Roel Verdult
 * Copyright (C) 2009-2013 Romuald Conty
 * Copyright (C) 2010-2012 Romain Tartière
 * Copyright (C) 2010-2013 Philippe Teuwen
 * Copyright (C) 2012-2013 Ludovic Rousseau
 * Additional contributors of this file:
 * Copyright (C) ...

Comments?

Original comment by yob...@gmail.com on 10 Mar 2013 at 12:03

GoogleCodeExporter commented 9 years ago
Why "Public" in the title?

"Platform independent Near Field Communication (NFC) library" should be enough.

Original comment by ludovic....@gmail.com on 10 Mar 2013 at 2:02

GoogleCodeExporter commented 9 years ago
I agree!

Original comment by romuald.conty on 10 Mar 2013 at 2:03

GoogleCodeExporter commented 9 years ago
(for header/AUTHORS proposals)

"Free/Libre Near Field Communication (NFC) library" may be better as the 
Windows support is not in main development stream...

BTW, "Platform independent Near Field Communication (NFC) library" is fine to 
me too.

Original comment by romuald.conty on 10 Mar 2013 at 2:05

GoogleCodeExporter commented 9 years ago
Thanks for your comments, headers updated as proposed in commits
* bf164220ee3b1f7ff9a1977774eeb2460043b686
* baa0f9ae36261825fbda4a554379634e23c75f5e
Minor changes can still be discussed on the mailing-list, I'm closing this 
issue for now.

Original comment by yob...@gmail.com on 10 Mar 2013 at 3:22