search

marcus905 / libnfc

Automatically exported from code.google.com/p/libnfc
GNU Lesser General Public License v3.0
0 stars 0 forks source link

Windows compilation broken with usbbus addition #236

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
In version 1.7.0 rc6

Fixed in windows-debug branch of
https://code.google.com/r/alexlian-windows-compatibility/

Simple fix where CMake is missing the reference to buses/usbbus

Original issue reported on code.google.com by alex.l...@gmail.com on 3 Mar 2013 at 5:34

GoogleCodeExporter commented 9 years ago 
While you're taking the compilation fix, I suggest taking this as well:

https://code.google.com/r/alexlian-windows-compatibility/source/detail?r=6c206c8
6589380bb43faace64649cc672188385d&name=windows-debug

I've cleaned up all the warnings in the Windows build. I aimed for portability 
with the formatting changes, so I'm hoping it's clean on the other platforms.

Original comment by alex.l...@gmail.com on 4 Mar 2013 at 6:28

GoogleCodeExporter commented 9 years ago 
Thanks!
As I made a lot of changes before I saw you patch, I cherry-picked your changes 
on the master.
Note that I made the addition of usbbus conditional in CMake, please check

Original comment by yob...@gmail.com on 7 Mar 2013 at 8:46