marcus905 / libnfc

Automatically exported from code.google.com/p/libnfc
GNU Lesser General Public License v3.0
0 stars 0 forks source link

cmake soversion doesn't match autotools #281

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Hi,

nfc soversion is 5:1:0

hence in cmake stuff we should do:
SET_TARGET_PROPERTIES(nfc PROPERTIES SOVERSION 5 VERSION 5.0.1)

I guess maintaining these two both Makefile.am and CMakeLists.txt is tedious, 
but autotools support is supposed to be dropped one day right ?

diff --git a/libnfc/CMakeLists.txt b/libnfc/CMakeLists.txt
index 66d2124..7a51bb0 100644
--- a/libnfc/CMakeLists.txt
+++ b/libnfc/CMakeLists.txt
@@ -89,7 +89,7 @@ IF(LIBUSB_FOUND)
   TARGET_LINK_LIBRARIES(nfc ${LIBUSB_LIBRARIES})
 ENDIF(LIBUSB_FOUND)

-SET_TARGET_PROPERTIES(nfc PROPERTIES SOVERSION 0)
+SET_TARGET_PROPERTIES(nfc PROPERTIES SOVERSION 5 VERSION 5.0.1)

 IF(WIN32)
   # Libraries that are windows specific

Original issue reported on code.google.com by julien.s...@gmail.com on 2 Jul 2014 at 6:58