Integrate pre-commit into the worflow

marcusbuffett / command-line-chess

A python program to play chess against an AI in the terminal.

MIT License

500 stars 162 forks source link

Integrate pre-commit into the worflow #45

Closed ClasherKasten closed 1 year ago

ClasherKasten commented 2 years ago

Tasks:

Add .pre-commit-config.yaml with the following hooks:
- end-of-file-fixer
- trailing-whitespace
- double-quote-string-fixer
- debug-statements
- check-ast
- mypy
- flake8
- autopep8
- add-trailing-comma
- pyupgrade
- reorder-python-imports
Run pre-commit run --all-files once
Eventually notice it in CONTRIBUTING.md under Pull Request Process

Hooks that are listed can be discussed. When claiming this issue and you want to add additional hooks , please first comment these hooks here so they also can be discussed.

Abdullah-Majid commented 2 years ago

can i be assigned this?

Abdullah-Majid commented 2 years ago

I don't think I have perms to push my changes - I've branched off the latest master and made the changes suggested. Wanted to get some initial feedback.

ClasherKasten commented 2 years ago

I don't think I have perms to push my changes - I've branched off the latest master and made the changes suggested.

For further clarification, could you please provide the output of git remote -v? My guess would be that you cloned the original repository (marcusbuffett/command-line-chess) and for that you probably don't have the write rights. If it is the case that you cloned marcusbuffett/command-line-chess, please fork the project first, push the feature on a new branch in your fork and finally open a Pull Request (PR).

Wanted to get some initial feedback.

If you open a new PR, I can give you some feedback via review.

Abdullah-Majid commented 2 years ago

https://github.com/marcusbuffett/command-line-chess/pull/48 apologies I'm new at this

mohebmithani commented 1 year ago

@ClasherKasten I've linked PR for this issue, please review it when possible.