search

marcusgreen / moodle-qtype_gapfill

Fill in the blanks question type with very easy to learn syntax
6 stars 20 forks source link

version required bump? #74

Closed aspark21 closed 2 years ago

aspark21 commented 3 years ago

Moodle: 3.5.18 Gapfill: latest master Does not occur in 3.9 builds so it's probably relying on core functions from higher Moodle versions. 3.5 is out of support, so probably best to bump version required.

questiontype_test::test_save_question

Error: Call to undefined method questiontype_test::assertIsArray()

/var/www/html/question/type/gapfill/tests/questiontype_test.php:115

/var/www/html/lib/phpunit/classes/advanced_testcase.php:80

To re-run:

 vendor/bin/phpunit "questiontype_test" question/type/gapfill/tests/questiontype_test.php
marcusgreen commented 3 years ago

Thanks Alistair, I will take a look and probably release an update. The age of supported versions was starting to look a little implausible.

marcusgreen commented 3 years ago

I took another look at this assertIsArray seems to be part of the phpunit testing code. I'm not going to bump the required version on this next minor release, but I will update it in the master branch so it is updated to at least 3.5 in the release after this.

marcusgreen commented 2 years ago

Bumped in subsequent release. Closing now, thank you Alistair