The file selection.js should be transferred to an amd module

marcusgreen / moodle-qtype_wordselect

langHighlight words by clicking e.g. select all nouns in this sentence

2 stars 10 forks source link

Closed mkassaei closed 5 years ago

mkassaei commented 5 years ago

The selection.js file in question/type/wordselect uses jquery and seems to cause problem when more than one script using jquery on a page.

I will be working on this

marcusgreen commented 5 years ago

Thanks for letting me know. Could you give me more details as it might be an issue with the companion question type gapfill.

marcusgreen commented 5 years ago

Hi mkassel, I didn't read the full header of your issue when I last looked. Now I understand it and doing that is quite clearly a very good thing.

marcusgreen commented 5 years ago

I have added some code to convert selection to use amd, let me know what you think. Improvements gratefully accepted.

timhunt commented 5 years ago

This is done, right? I think it can be closed.

marcusgreen commented 5 years ago

Done, closing