Wordselect does not need to require jquery on the page

marcusgreen / moodle-qtype_wordselect

langHighlight words by clicking e.g. select all nouns in this sentence

2 stars 10 forks source link

Wordselect does not need to require jquery on the page #20

Closed mkassaei closed 4 years ago

mkassaei commented 4 years ago

Hi Marcus, The function find_standard_scripts() in questiontype.php calling the parent and $PAGE->requires->jquery() afterward. This causing an issue as you can see on attachment in filter/embedquestion plugin. I have deleted this method, since the parent method doing the job and there is no need to require jquery agin. I think this is not needed anymore, since the selection.js was transferred to amd/src...

wordselect_jquery_issue

marcusgreen commented 4 years ago

Thanks Mahmoud, I ought to have an automatic test somewhere to confirm that it works properly with embed question. I am just wrangling another issue with Tim Hunt (see other open issue) and testing against the latest 3.8 alpha.