marcusgreen / moodle-qtype_wordselect

langHighlight words by clicking e.g. select all nouns in this sentence
2 stars 10 forks source link

Selection fails if there is multimedia/audio before the text #33

Closed marcusgreen closed 4 years ago

marcusgreen commented 4 years ago

Embedding an audio file before the text means that selection will not work. It seems to work if the audio comes after the selectable text.

As discussed here https://moodle.org/mod/forum/discuss.php?d=404036

marcusgreen commented 4 years ago

If I turn off the multimedia filter the audio plays and the question also works, so I will investigate the multimedia filter further.

marcusgreen commented 4 years ago

It seems that the multimedia filter causes a mismatch between the id of the selectable items displyed in rendering and those stored in the database. So p18 might be in the question attempt but the renderer shows it as p60 (or whatever)

marcusgreen commented 4 years ago

Moved filter lower in renderer, see https://github.com/marcusgreen/moodle-qtype_wordselect/commit/ff25b9038e869740e8866d16e18417b7b204e4a1

marcusgreen commented 4 years ago

The master branch contains a fix as in my last comment and I will close this issue after I update the plugins database with the latest version.

marcusgreen commented 4 years ago

Fixed in 2.44