Fix Behat tests for mlang and mlang2 filters

marcusgreen / moodle-qtype_wordselect

langHighlight words by clicking e.g. select all nouns in this sentence

2 stars 10 forks source link

Fix Behat tests for mlang and mlang2 filters #49

Closed AnupamaSarjoshi closed 2 years ago

AnupamaSarjoshi commented 2 years ago

Hi Marcus,

I have made changes to fix the Behat tests, testing mlang and mlang2 filters to work with qtype_wordselect.

Changes done:

To skip mlang2 filter test, if the respective filter is not installed.
For the second test (Scenario: Create a question and check (core) mlang works as expected), it seems that if a site uses a child language pack, then the first span tag must be the parent language. https://docs.moodle.org/400/en/Multi-language_content_filter

Could you please review?

Thanks, Anupama

marcusgreen commented 2 years ago

Thank you for that. I did quite a bit of work on mlang/mlang2 and I have a feeling that it doesn't entirely work as expected at all due to the dependence on the position of the selectable words and how that differs between when you enter them and when it is rendered. I think this happens if you have additional inserts such as images. However based on my 10 second glance your change looks good and I will review properly ASAP.

marcusgreen commented 2 years ago

Ooh, looks like you did get core mlang to work, glad I left in the commented out bits so you could see what I was thinking.

AnupamaSarjoshi commented 2 years ago

Thanks so much Marcus for a quick review on that. Yes, while looking at the mlang2 Behat failure just tried to have a look at mlang as well. Hope that would be useful :)

For mlang2, the test works fine if the mlang2 filter is installed otherwise the test gets skipped.

marcusgreen commented 2 years ago

Where do you work?

AnupamaSarjoshi commented 2 years ago

Sorry forgot to mention that. I work with OU. Have recently moved into developer role. Working in the same team as @timhunt

marcusgreen commented 2 years ago

Cool!