Closed AnupamaSarjoshi closed 1 year ago
Thank you for that. I did quite a bit of work on mlang/mlang2 and I have a feeling that it doesn't entirely work as expected at all due to the dependence on the position of the selectable words and how that differs between when you enter them and when it is rendered. I think this happens if you have additional inserts such as images. However based on my 10 second glance your change looks good and I will review properly ASAP.
Ooh, looks like you did get core mlang to work, glad I left in the commented out bits so you could see what I was thinking.
Thanks so much Marcus for a quick review on that. Yes, while looking at the mlang2 Behat failure just tried to have a look at mlang as well. Hope that would be useful :)
For mlang2, the test works fine if the mlang2 filter is installed otherwise the test gets skipped.
Where do you work?
Sorry forgot to mention that. I work with OU. Have recently moved into developer role. Working in the same team as @timhunt
Cool!
Hi Marcus,
I have made changes to fix the Behat tests, testing mlang and mlang2 filters to work with qtype_wordselect.
Changes done:
Could you please review?
Thanks, Anupama