search

marcusgreen / moodle-qtype_wordselect

langHighlight words by clicking e.g. select all nouns in this sentence
2 stars 10 forks source link

Fix PHP8.1 deprecated errors related to preg_split #51

Closed AnupamaSarjoshi closed 1 year ago

AnupamaSarjoshi commented 1 year ago

Hi Marcus,

We found PHP deprecated error in preg_split when updated to PHP 8.1. Also some of the the Behat tests are failing. Hence have done the changes to fix those issues in question.php. Could you please review?

Errors: Deprecated: preg_split(): Passing null to parameter #3 ($limit) of type int is deprecated in /var/www/html/moodle/question/type/wordselect/question.php on line 141

preg_split(): Passing null to parameter #3 ($limit) of type int is deprecated in [dirroot]/question/type/wordselect/question.php on line 130

Thanks, Anupama.

marcusgreen commented 1 year ago

Thank you for that, Tim Hunt mentioned it would be coming. I had similar things in my other question type gapfill. I will review and merge as soon as I can.

marcusgreen commented 1 year ago

Thank you (again) Open University. My Moodle heroes.