marcusgreen / moodle-qtype_wordselect

langHighlight words by clicking e.g. select all nouns in this sentence
2 stars 10 forks source link

Updated to support PHP 8.2 #52

Closed timhunt closed 8 months ago

timhunt commented 8 months ago

The main changes here (third commit) are changes to stop PHP 8.2 giving deprecated warnings about undefined fields like

Exception: Moodle exception: Exception - Unknown error type: Creation of dynamic property qtype_wordselect_question::$correctfeedback is deprecated in [dirroot]\question\type\questiontypebase.php on line 1091 More information about this error

Along the way, I corrected where 'init' is called.

Also: I fixed Behat tests affecte by the change to the wording of the "Save preview options and start again" button.

And, I updated the Moodle plugin CI config to test against all the Moodle versions that the plugins DB claims are supported, and a range of PHP versions.

I hope this is useful.

marcusgreen commented 8 months ago

Thanks Tim, "saverestart" in behat is something I did not know about.

marcusgreen commented 8 months ago

Thanks Tim, looks good and reminds me that in future I should test against the latest supported version of PHP.