search

marcusgreen / moodle-tool_driprelease

Drip (automate) the availability of moodle course activities over time
3 stars 1 forks source link

SQL coding style - Indentation #1

Open purnendudash opened 1 month ago

purnendudash commented 1 month ago

Sql statement should follow this indentation style - https://moodledev.io/general/development/policies/codingstyle/sql#indentation

https://github.com/marcusgreen/moodle-tool_driprelease/blob/dd7cba728d18276f9d609823532ec43a99d32f40/lib.php#L389

marcusgreen commented 1 month ago

Can I confirm you mean it should have a line break after the keywords like this


$sql = 'SELECT sequence FROM {course_sections} 
        WHERE course = :course
        AND sequence > "" 
        ORDER BY section';

Always delighted to get feedback, I am very keen on complying with the coding standards.

marcusgreen commented 4 weeks ago

I have formatted the sql as you can see from that commit above.