marcuslowhuiyu / pe

0 stars 0 forks source link

Unable to add items from multiple suppliers #14

Open marcuslowhuiyu opened 1 year ago

marcuslowhuiyu commented 1 year ago

image.png

I was unable to add multiple suppliers for the Egg item. This behaviour was not mentioned anywhere in the UG. It might also not be realistic to assume that the canteen vendors would only source for each ingredient only from a singular supplier.

E.g. Different spices from different suppliers might have different taste.

soc-pe-bot commented 1 year ago

Team's Response

Response

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unable to add item from new supplier, even when existing supply ran out

image.png

I'm not really sure if there is a need to remember which supplier a particular ingredient came from. If I had two suppliers for potatoes, for example, it is not possible for me to procure from both. If my main supplier were to run out of stock for an item and I want to switch to another supplier, I cannot add that item from another supplier into the inventory.

Low severity as it is relatively uncommon for suppliers to run out of their item, or a need for the user to change supplier.


[original: nus-cs2103-AY2223S1/pe-interim#826] [original labels: type.FeatureFlaw severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

As mentioned by tester it is not common for vendors to have two different suppliers for the same item. Hence, currently it only makes sense for an item to be able to be added only after switching suppliers , hence the need for the user to delete current item from list then add new item from different supplier. To prevent duplicates

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I believe that the assumption that all vendors will only secure an ingredient from a single supplier is an unreasonable assumption that is not grounded or backed by any evidence.

As mentioned in my bug report, it could be the case where different spices from different vendors provide different taste, thus the vendor might want to procure spices from multiple vendors.

Additionally, even if this is the intended behaviour, this behaviour is not mentioned anywhere in the UG.