marcusmolchany / react-jazzicon

React component for danfinlay/jazzicon
https://marcusmolchany.github.io/react-jazzicon
MIT License
42 stars 16 forks source link

both dependency and peer dependency on React #10

Closed cellog closed 2 years ago

cellog commented 5 years ago

react-jazzicon depends on React 16 but has a peer dependency of React 15. This results in an npm warning. It would be great if both react and react-dom were peer dependencies with version ranges

marcusmolchany commented 5 years ago

hey thanks for calling this out @cellog, i will take a look tonight

marcusmolchany commented 5 years ago

got busy and haven't had a chance to look at this. if someone wants to pr i'll review