search

marcusmoller / pyorpg-client

Client for the PyORPG project
Other
56 stars 48 forks source link

All UTF-8 characters aren't accepted when sent in chat #14

Open marcusmoller opened 11 years ago

marcusmoller commented 11 years ago

When trying to sent characters such as "æ", "ø" and "å" through chat, the game crashes.

Could either be a problem with the GUI or with JSON.

marcusmoller commented 11 years ago

A fix is to add ensure_ascii=False to ALL json.dumps(), but that would just be horrible.

Irtorius commented 11 years ago

Should be an easier way to fix the encoding problem. It's way over my head though

NightBlues commented 11 years ago

what do you think about encoding all user input string with base64? btw, replacing string c = (e.unicode).encode('latin-1') to c = e.unicode in file src/pgu/input.py makes game not to crash (but twisted denies to send unicode string to server and inputed specific letters looks like rectangles - i think its font rendering problem) i tryied to encode with base64 login and password strings before sending and decoding on the server side and login proceeds, but this patches must be done for client and server at the same time and problem with letters view is not solved...if this solution is acceptable - i'll make pull request

marcusmoller commented 11 years ago

@NightBlues I would be very interested in seeing your pull request, so please do make one if you're up for it.

Encoding sounds like a great idea, and it reminded me that I need encrypt and store the passwords as MD5 hashes as well.