search

marcusmoller / pyorpg-client

Client for the PyORPG project
Other
56 stars 48 forks source link

Alert message accessiblity #25

Closed Irtorius closed 11 years ago

Irtorius commented 11 years ago

I think it should work now, now it's only changing what I added and removed, and for some reason, one of your changes jumped along. Anyway, I hope it works this time

marcusmoller commented 11 years ago

With the way you're handling the dialog, there really is no reason to use a class.

You're only using the init function of the class, which effectively makes it a function. It would be better to rewrite the alertMessageDialog() into a function than a class.

marcusmoller commented 11 years ago

I've created a function rather than a class. You can have a look here: https://github.com/marcusmoller/pyorpg-client/commit/df18cafecaf9305b87cc7d8c2f449ab586850327

Irtorius commented 11 years ago

Okay good to know, I will remember that. Nice looking function, haha