Enhance hover support and fix link open

marcusolsson / obsidian-projects

Plain text project planning in Obsidian

Apache License 2.0

1.42k stars 56 forks source link

Enhance hover support and fix link open #898

Closed H3mul closed 3 months ago

H3mul commented 4 months ago

A quick little adjustment I was missing: using hover preview to quickly go through notes in Board view.

I also took the opportunity adjust the hover treatment of Table view to a more preferred setup: instead of handling the meta keys in projects, we should register a new hover view source, that way the meta key treatment can be toggled inside Page Preview settings:

Tested and made sure this works with both core Page Preview and the Hover Editor plugin.

Acylation commented 4 months ago

Nice catch!

H3mul commented 3 months ago

Since InternalLink is moving to obsidian-projects, perhaps take a look at my PR to obsidian-svelte: https://github.com/marcusolsson/obsidian-svelte/pull/9

I think we can include it here painlessly

Edit: nvm, youre already on it :)

Acylation commented 3 months ago

Hi I just saw https://github.com/marcusolsson/obsidian-svelte/pull/9. Thanks for pointing out the problem and the fix! Since we gonna use a mocked InternalLink component in this PR (59d87b6), here I also include your fix as a temporary solution. I will contribute this component back after some refactoring (decouple dom-event handler and the hover-trigger).

Closes #780.