search

marcusolsson / obsidian-vale

A Vale client for Obsidian.
MIT License
85 stars 8 forks source link

Vale check produces no results #16

Open npivic opened 2 years ago

npivic commented 2 years ago

Running Obsidian v0.15.2, the latest version of Vale.

Problem description

  1. I select a file to fix.
  2. I run the command Vale: Check document.

Expected result: the usual pane that produces vale results.

Actual results: an empty Vale window:

image

Resolution attempts

I've updated all of my Obsidian plugins and am running the latest version of Obsidian.

I've restarted Obsidian.

I've disabled and then enabled Vale.

universemaster commented 2 years ago

You say you are using Obsidian v0.15.2.

The below is from the README.

I, too, hope that the developers of this extension make it compatible with 13+.

Obsidian Vale doesn't yet support the new editor that was introduced in Obsidian 13.

To continue using the plugin for version 13, you can enable the Legacy Editor.

Open Settings -> Editor. Enable Legacy Editor. Restart Obsidian.

marcusolsson commented 2 years ago

Hey! The API has changed significantly since I wrote the plugin, and I haven't had the chance to sit down to understand the current API. I'm working on it now though, and I sincerely hope to have a new version out within the next few weeks.

npivic commented 1 year ago

Hi @marcusolsson! Just a very curious question: do you plan to update the plugin soonishly? I have no problems with using it when I switch to the Legacy editor, just wanted to ask. :) Yet again, thanks for having created it, it's very useful to me.

marcusolsson commented 1 year ago

I've been working on another plugin for Obsidian October that has been taking up my time. I plan on working on the Vale plugin again once it's published.

I was hoping it would be a relatively isolated fix, but I've realized the plugin needs a major overhaul. Mostly due to the API change mentioned above, but partly because I've learned more about Obsidian development since I wrote it.

It's my intention to continue developing this plugin (I need it myself 😅), but I think it's better not to make any more promises at this point.

chlohal commented 1 year ago

Would you accept any PRs to make it compatible? I couldn't find any information about contributions in the README, so I thought I should ask :) sorry!

marcusolsson commented 1 year ago

Absolutely! ❤️

q7z commented 1 year ago

Thank you so much for this Marcus! Following for updates if/when you get to this :D

npivic commented 1 year ago

Thanks, @marcusolsson ! Lovely work!