search

marcusramberg / mojolicious-plugin-promiseactions

3 stars 2 forks source link

t/app.t fails (with newer Mojolicious?) #8

Open eserte opened 4 years ago

eserte commented 4 years ago

On my smokers:

#   Failed test 'Promise is passed through'
#   at t/app.t line 58.
#          got: ''
#     expected: 'Mojo::Promise'

#   Failed test 'Second argument passed through ok'
#   at t/app.t line 59.
#          got: undef
#     expected: 'hello'
# Looks like you failed 2 tests of 14.
t/app.t ....... 
Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/14 subtests

Statistical analysis suggests that newer Mojolicious (8.29 or so) is causing the problem:

****************************************************************
Regression 'mod:Mojolicious'
****************************************************************
Name                   Theta          StdErr     T-stat
[0='const']           1.0000          0.0000    35650920366505776.00
[1='eq_8.09']         0.0000          0.0000       1.04
[2='eq_8.10']         0.0000          0.0000       6.29
[3='eq_8.11']         0.0000          0.0000       5.84
[4='eq_8.13']         0.0000          0.0000       7.00
[5='eq_8.14']        -0.0000          0.0000      -0.79
[6='eq_8.15']         0.0000          0.0000       5.84
[7='eq_8.17']         0.0000          0.0000       1.75
[8='eq_8.27']        -0.0000          0.0000      -2.80
[9='eq_8.29']        -1.0000          0.0000    -10512882875120150.00
[10='eq_8.30']       -1.0000          0.0000    -17825460183252890.00
[11='eq_8.31']       -1.0000          0.0000    -16806005031131886.00
[12='eq_8.32']       -1.0000          0.0000    -27869606456544788.00

R^2= 1.000, N= 151, K= 13
****************************************************************
zoffixznet commented 3 years ago

Confirming with Mojolicious 8.61:

$ cpanm -v Mojolicious::Plugin::PromiseActions
cpanm (App::cpanminus) 1.7044 on perl 5.028000 built for i686-linux-multi
Work directory is /home/zoffix/.cpanm/work/1605641511.12197
You have make /usr/bin/make
You have LWP 6.43
You have /bin/tar: tar (GNU tar) 1.26
Copyright (C) 2011 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by John Gilmore and Jay Fenlason.
You have /usr/bin/unzip
Searching Mojolicious::Plugin::PromiseActions () on cpanmetadb ...
--> Working on Mojolicious::Plugin::PromiseActions
Fetching http://www.cpan.org/authors/id/M/MR/MRAMBERG/Mojolicious-Plugin-PromiseActions-0.08.tar.gz ... OK
Unpacking Mojolicious-Plugin-PromiseActions-0.08.tar.gz
Mojolicious-Plugin-PromiseActions-0.08/
Mojolicious-Plugin-PromiseActions-0.08/cpanfile
Mojolicious-Plugin-PromiseActions-0.08/.vstags
Mojolicious-Plugin-PromiseActions-0.08/Changes
Mojolicious-Plugin-PromiseActions-0.08/MANIFEST
Mojolicious-Plugin-PromiseActions-0.08/t/
Mojolicious-Plugin-PromiseActions-0.08/README.md
Mojolicious-Plugin-PromiseActions-0.08/META.yml
Mojolicious-Plugin-PromiseActions-0.08/lib/
Mojolicious-Plugin-PromiseActions-0.08/.ship.conf
Mojolicious-Plugin-PromiseActions-0.08/Makefile.PL
Mojolicious-Plugin-PromiseActions-0.08/META.json
Mojolicious-Plugin-PromiseActions-0.08/lib/Mojolicious/
Mojolicious-Plugin-PromiseActions-0.08/lib/Mojolicious/Plugin/
Mojolicious-Plugin-PromiseActions-0.08/lib/Mojolicious/Plugin/PromiseActions.pm
Mojolicious-Plugin-PromiseActions-0.08/t/reject.t
Mojolicious-Plugin-PromiseActions-0.08/t/app.t
Mojolicious-Plugin-PromiseActions-0.08/t/under.t
Mojolicious-Plugin-PromiseActions-0.08/t/00-basic.t
Entering Mojolicious-Plugin-PromiseActions-0.08
Checking configure dependencies from META.json
Checking if you have ExtUtils::MakeMaker 6.58 ... Yes (7.38)
Running Makefile.PL
Configuring Mojolicious-Plugin-PromiseActions-0.08 ... Checking if your kit is complete...
Looks good
Generating a Unix-style Makefile
Writing Makefile for Mojolicious::Plugin::PromiseActions
Writing MYMETA.yml and MYMETA.json
OK
Checking dependencies from MYMETA.json ...
Checking if you have Test::More 0.88 ... Yes (1.302172)
Checking if you have Scalar::Util 0 ... Yes (1.54)
Checking if you have Mojolicious 8.04 ... Yes (8.61)
Building and testing Mojolicious-Plugin-PromiseActions-0.08 ... cp lib/Mojolicious/Plugin/PromiseActions.pm blib/lib/Mojolicious/Plugin/PromiseActions.pm
Manifying 1 pod document
PERL_DL_NONLAZY=1 "/home/zoffix/perl5/perlbrew/perls/perl-5.28.0/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/00-basic.t .. ok   
t/app.t ....... 1/? 
#   Failed test 'Promise is passed through'
#   at t/app.t line 58.
#          got: ''
#     expected: 'Mojo::Promise'

#   Failed test 'Second argument passed through ok'
#   at t/app.t line 59.
#          got: undef
#     expected: 'hello'
Unhandled rejected promise: HI at /home/zoffix/perl5/perlbrew/perls/perl-5.28.0/lib/site_perl/5.28.0/Mojo/Reactor/Poll.pm line 131.
# Looks like you failed 2 tests of 14.
t/app.t ....... Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/14 subtests 
t/reject.t .... ok   
t/under.t ..... ok    

Test Summary Report
-------------------
t/app.t     (Wstat: 512 Tests: 14 Failed: 2)
  Failed tests:  4-5
  Non-zero exit status: 2
Files=4, Tests=38,  5 wallclock secs ( 0.08 usr  0.00 sys +  3.62 cusr  0.21 csys =  3.91 CPU)
Result: FAIL
Failed 1/4 test programs. 2/38 subtests failed.
make: *** [test_dynamic] Error 255
FAIL
! Installing Mojolicious::Plugin::PromiseActions failed. See /home/zoffix/.cpanm/work/1605641511.12197/build.log for details. Retry with --force to force install it.
hussam-qasem commented 1 year ago

Still fails with Mojolicious 9.31

cpanm -v Mojolicious::Plugin::PromiseActions ``` cpanm (App::cpanminus) 1.7046 on perl 5.036000 built for darwin-thread-multi-2level Work directory is /Users/user/.cpanm/work/1681637518.8285 You have make /usr/bin/make You have LWP 6.68 You have /usr/bin/tar: bsdtar 3.5.1 - libarchive 3.5.1 zlib/1.2.11 liblzma/5.0.5 bz2lib/1.0.8 You have /usr/bin/unzip Searching Mojolicious::Plugin::PromiseActions () on cpanmetadb ... --> Working on Mojolicious::Plugin::PromiseActions Fetching http://www.cpan.org/authors/id/M/MR/MRAMBERG/Mojolicious-Plugin-PromiseActions-0.08.tar.gz ... OK Unpacking Mojolicious-Plugin-PromiseActions-0.08.tar.gz x Mojolicious-Plugin-PromiseActions-0.08/ x Mojolicious-Plugin-PromiseActions-0.08/cpanfile x Mojolicious-Plugin-PromiseActions-0.08/.vstags x Mojolicious-Plugin-PromiseActions-0.08/Changes x Mojolicious-Plugin-PromiseActions-0.08/MANIFEST x Mojolicious-Plugin-PromiseActions-0.08/t/ x Mojolicious-Plugin-PromiseActions-0.08/README.md x Mojolicious-Plugin-PromiseActions-0.08/META.yml x Mojolicious-Plugin-PromiseActions-0.08/lib/ x Mojolicious-Plugin-PromiseActions-0.08/.ship.conf x Mojolicious-Plugin-PromiseActions-0.08/Makefile.PL x Mojolicious-Plugin-PromiseActions-0.08/META.json x Mojolicious-Plugin-PromiseActions-0.08/lib/Mojolicious/ x Mojolicious-Plugin-PromiseActions-0.08/lib/Mojolicious/Plugin/ x Mojolicious-Plugin-PromiseActions-0.08/lib/Mojolicious/Plugin/PromiseActions.pm x Mojolicious-Plugin-PromiseActions-0.08/t/reject.t x Mojolicious-Plugin-PromiseActions-0.08/t/app.t x Mojolicious-Plugin-PromiseActions-0.08/t/under.t x Mojolicious-Plugin-PromiseActions-0.08/t/00-basic.t Entering Mojolicious-Plugin-PromiseActions-0.08 Checking configure dependencies from META.json Checking if you have ExtUtils::MakeMaker 6.58 ... Yes (7.64) Running Makefile.PL Configuring Mojolicious-Plugin-PromiseActions-0.08 ... Checking if your kit is complete... Looks good Generating a Unix-style Makefile Writing Makefile for Mojolicious::Plugin::PromiseActions Writing MYMETA.yml and MYMETA.json OK Checking dependencies from MYMETA.json ... Checking if you have Test::More 0.88 ... Yes (1.302190) Checking if you have Scalar::Util 0 ... Yes (1.62) Checking if you have Mojolicious 8.04 ... Yes (9.31) Building and testing Mojolicious-Plugin-PromiseActions-0.08 ... cp lib/Mojolicious/Plugin/PromiseActions.pm blib/lib/Mojolicious/Plugin/PromiseActions.pm Manifying 1 pod document PERL_DL_NONLAZY=1 "/usr/local/Cellar/perl/5.36.0/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/00-basic.t .. ok t/app.t ....... 1/? # Failed test 'Promise is passed through' # at t/app.t line 58. # got: '' # expected: 'Mojo::Promise' # Failed test 'Second argument passed through ok' # at t/app.t line 59. # got: undef # expected: 'hello' Unhandled rejected promise: A response has already been rendered at /Users/user/perl5/lib/perl5/Mojolicious/Controller.pm line 154. at /Users/user/perl5/lib/perl5/Mojo/Reactor/Poll.pm line 129. Unhandled rejected promise: HI at /Users/user/perl5/lib/perl5/Mojo/Reactor/Poll.pm line 129. # Looks like you failed 2 tests of 14. t/app.t ....... Dubious, test returned 2 (wstat 512, 0x200) Failed 2/14 subtests t/reject.t .... Unhandled rejected promise: A response has already been rendered at /Users/user/perl5/lib/perl5/Mojolicious/Controller.pm line 154. at /Users/user/perl5/lib/perl5/Mojo/Reactor/Poll.pm line 129. t/reject.t .... ok t/under.t ..... 1/? Unhandled rejected promise: A response has already been rendered at /Users/user/perl5/lib/perl5/Mojolicious/Controller.pm line 154. at /Users/user/perl5/lib/perl5/Mojo/Reactor/Poll.pm line 129. t/under.t ..... ok Test Summary Report ------------------- t/app.t (Wstat: 512 (exited 2) Tests: 14 Failed: 2) Failed tests: 4-5 Non-zero exit status: 2 Files=4, Tests=38, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.18 cusr 0.18 csys = 1.40 CPU) Result: FAIL Failed 1/4 test programs. 2/38 subtests failed. make: *** [test_dynamic] Error 22 FAIL ! Installing Mojolicious::Plugin::PromiseActions failed. See /Users/user/.cpanm/work/1681637518.8285/build.log for details. Retry with --force to force install it. ```