search

marcusrbrown / copiloting

A collection of building blocks for creating AI agents and chatbots.
MIT License
1 stars 1 forks source link

chore(deps): update dependency @sveltejs/kit to v1.15.2 [SECURITY] - autoclosed #253

Closed mrbro-bot[bot] closed 6 months ago

mrbro-bot[bot] commented 6 months ago

This PR contains the following updates:

Package Change Age Confidence
@sveltejs/kit (source) 1.5.0 -> 1.15.2 age confidence

GitHub Vulnerability Alerts

CVE-2023-29003

Summary

The SvelteKit framework offers developers an option to create simple REST APIs. This is done by defining a +server.js file, containing endpoint handlers for different HTTP methods.

SvelteKit provides out-of-the-box cross-site request forgery (CSRF) protection to it’s users. The protection is implemented at kit/src/runtime/server/respond.js#L52. While the implementation does a sufficient job in mitigating common CSRF attacks, the protection can be bypassed by simply specifying a different Content-Type header value.

Details

The CSRF protection is implemented using the code shown below.

const forbidden =
  // (1)
  request.method === 'POST' &&
  // (2)
  request.headers.get('origin') !== url.origin &&
  // (3)
  is_form_content_type(request);

if (forbidden) {
  // (4)
  const csrf_error = error(403, `Cross-site ${request.method} form submissions are forbidden`);
  if (request.headers.get('accept') === 'application/json') {
    return json(csrf_error.body, { status: csrf_error.status });
  }
  return text(csrf_error.body.message, { status: csrf_error.status });
}

If the incoming request specifies a POST method (1), the protection will compare the server’s origin with the value of the HTTP Origin header (2). A mismatch between these values signals that a potential attack has been detected. The final check is performed on the request’s Content-Type header (3) whether the value is either application/x-www-form-urlencoded or multipart/form-data (kit/src/utils/http.js#L71). If all the previous checks pass, the request will be rejected with an 403 error response (4).

The is_form_content_type validation is not sufficient to mitigate all possible variations of this type of attack. If a CSRF attack is performed with the Content-Type header set to text/plain, the protection will be circumvented and the request will be processed by the endpoint handler.

Impact

If abused, this issue will allow malicious requests to be submitted from third-party domains, which can allow execution of operations within the context of the victim's session, and in extreme scenarios can lead to unauthorized access to users’ accounts.

Remediation

SvelteKit 1.15.1 updates the is_form_content_type function call in the CSRF protection logic to include text/plain.

As additional hardening of the CSRF protection mechanism against potential method overrides, SvelteKit 1.15.1 is now performing validation on PUT, PATCH and DELETE methods as well. This latter hardening is only needed to protect users who have put in some sort of ?_method= override feature themselves in their handle hook, so that the request that resolve sees could be PUT/PATCH/DELETE when the browser issues a POST request.

CVE-2023-29008

Summary

The SvelteKit framework offers developers an option to create simple REST APIs. This is done by defining a +server.js file, containing endpoint handlers for different HTTP methods.

SvelteKit provides out-of-the-box cross-site request forgery (CSRF) protection to its users. The protection is implemented at kit/src/runtime/server/respond.js. While the implementation does a sufficient job of mitigating common CSRF attacks, the protection can be bypassed by simply specifying an upper-cased Content-Type header value. The browser will not send uppercase characters on form submission, but this check does not block all expected cross-site requests: https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS#simple_requests

Details

The CSRF protection is implemented using the code shown below.

        const forbidden =
            is_form_content_type(request) &&
            (request.method === 'POST' ||
                request.method === 'PUT' ||
                request.method === 'PATCH' ||
                request.method === 'DELETE') &&
            request.headers.get('origin') !== url.origin;

        if (forbidden) {
            const csrf_error = error(403, `Cross-site ${request.method} form submissions are forbidden`);
            if (request.headers.get('accept') === 'application/json') {
                return json(csrf_error.body, { status: csrf_error.status });
            }
            return text(csrf_error.body.message, { status: csrf_error.status });
        }

If the incoming request specifies a POST/PUT/PATCH/DELETE method, the protection will compare the server’s origin with the value of the HTTP Origin header. A mismatch between these values signals that a potential attack has been detected. The final check is performed on the request’s Content-Type header whether the value is either application/x-www-form-urlencoded, multipart/form-data or text/plain. If all the previous checks pass, the request will be rejected with an 403 error response. However, is_form_content_type, which is responsible for checking the value of the Content-Type header, is not sufficient to mitigate all possible variations of this type of attack. Since this function is checking Content-Type with lower-cased values, and the browser accepts upper-cased Content-Type header to be sent, a CSRF attack performed with the Content-Type header that contains an upper-cased character (e.g., text/plaiN) can circumvent the protection and the request will be processed by the endpoint handler.

Impact

If abused, this issue will allow malicious requests to be submitted from third-party domains, which can allow execution of operations within the context of the victim's session, and in extreme scenarios can lead to unauthorized access to users’ accounts. This may lead to all POST operations requiring authentication being allowed in the following cases:

  1. If the target site sets SameSite=None on its auth cookie and the user visits a malicious site in a Chromium-based browser
  2. If the target site doesn't set the SameSite attribute explicitly and the user visits a malicious site with Firefox/Safari with tracking protections turned off.
  3. If the user is visiting a malicious site with a very outdated browser.

Remediations

It is preferred to update to SvelteKit 1.15.2. It is also recommended to explicitly set SameSite to a value other than None on authentication cookies especially if the upgrade cannot be done in a timely manner.

Release Notes

sveltejs/kit (@​sveltejs/kit) ### [`v1.15.2`](https://togithub.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#1152) [Compare Source](https://togithub.com/sveltejs/kit/compare/@sveltejs/kit@1.15.1...@sveltejs/kit@1.15.2) ##### Patch Changes - fix: address security advisory [CVE-2023-29008](https://togithub.com/sveltejs/kit/security/advisories/GHSA-gv7g-x59x-wf8f) by doing a case-insensitive comparison when checking header value ([`ba436c66`](https://togithub.com/sveltejs/kit/commit/ba436c6685e751d968a960fbda65f24cf7a82e9f)) ### [`v1.15.1`](https://togithub.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#11511) [Compare Source](https://togithub.com/sveltejs/kit/compare/@sveltejs/kit@1.15.0...@sveltejs/kit@1.15.1) ##### Patch Changes - chore: more compact representation for invalidated search param ([#​9708](https://togithub.com/sveltejs/kit/pull/9708)) - chore: fix import path to app script on windows ([#​9743](https://togithub.com/sveltejs/kit/pull/9743)) - fix: make $app/navigation more resilient to bundler reordering ([#​9808](https://togithub.com/sveltejs/kit/pull/9808)) - fix: page load `fetch()` now accepts the same input types for the body as the native fetch function ([#​9801](https://togithub.com/sveltejs/kit/pull/9801)) - fix: handle preload and filterSerializedResponseHeaders in sequence function ([#​9741](https://togithub.com/sveltejs/kit/pull/9741)) ### [`v1.15.0`](https://togithub.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#1150) [Compare Source](https://togithub.com/sveltejs/kit/compare/@sveltejs/kit@1.14.0...@sveltejs/kit@1.15.0) ##### Minor Changes - feat: expose stronger typed `SubmitFunction` through `./$types` ([#​9201](https://togithub.com/sveltejs/kit/pull/9201)) ##### Patch Changes - fix: throw error when file can't be found in Vite manifest ([#​9558](https://togithub.com/sveltejs/kit/pull/9558)) - fix: make `error.message` enumerable when sending `ssrLoadModule` error to client ([#​9440](https://togithub.com/sveltejs/kit/pull/9440)) - fix: pass `publicDir` Vite config in SSR ([#​9565](https://togithub.com/sveltejs/kit/pull/9565)) - fix: balance parentheses in error about wrong content type for action ([#​9513](https://togithub.com/sveltejs/kit/pull/9513)) ### [`v1.14.0`](https://togithub.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#1140) [Compare Source](https://togithub.com/sveltejs/kit/compare/@sveltejs/kit@1.13.0...@sveltejs/kit@1.14.0) ##### Minor Changes - feat: add HMR to fallback error pages during dev ([#​9497](https://togithub.com/sveltejs/kit/pull/9497)) ##### Patch Changes - fix: add `submitter` type to `SumbitFunction` ([#​9484](https://togithub.com/sveltejs/kit/pull/9484)) ### [`v1.13.0`](https://togithub.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#1130) [Compare Source](https://togithub.com/sveltejs/kit/compare/@sveltejs/kit@1.12.0...@sveltejs/kit@1.13.0) ##### Minor Changes - feat: add dark mode styles to default error page ([#​9460](https://togithub.com/sveltejs/kit/pull/9460)) ##### Patch Changes - fix: recover from errors during dev by reloading ([#​9441](https://togithub.com/sveltejs/kit/pull/9441)) ### [`v1.12.0`](https://togithub.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#1120) [Compare Source](https://togithub.com/sveltejs/kit/compare/@sveltejs/kit@1.11.0...@sveltejs/kit@1.12.0) ##### Minor Changes - feat: expose submitter in use:enhance SubmitFunction ([#​9425](https://togithub.com/sveltejs/kit/pull/9425)) - feat: add data-sveltekit-keepfocus and data-sveltekit-replacestate options to links (requires Svelte version 3.56 for type-checking with `svelte-check`) ([#​9019](https://togithub.com/sveltejs/kit/pull/9019)) ##### Patch Changes - fix: don't start debugger on 404s ([#​9424](https://togithub.com/sveltejs/kit/pull/9424)) - fix: handle srcset attributes with newline after comma ([#​9388](https://togithub.com/sveltejs/kit/pull/9388)) - fix: allow tsconfig to extend multiple other tsconfigs ([#​9413](https://togithub.com/sveltejs/kit/pull/9413)) - chore: update Undici to 5.21.0 ([#​9417](https://togithub.com/sveltejs/kit/pull/9417)) ### [`v1.11.0`](https://togithub.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#1110) [Compare Source](https://togithub.com/sveltejs/kit/compare/@sveltejs/kit@1.10.0...@sveltejs/kit@1.11.0) ##### Minor Changes - feat: pause on debugger when falling back to full page reload during development ([#​9305](https://togithub.com/sveltejs/kit/pull/9305)) - feat: expose `base` via `$service-worker`, make paths relative ([#​9250](https://togithub.com/sveltejs/kit/pull/9250)) ##### Patch Changes - fix: don't automatically prerender non-SSR'd pages ([#​9352](https://togithub.com/sveltejs/kit/pull/9352)) - fix: use 308 responses for trailing slash redirects, instead of 301s ([#​9351](https://togithub.com/sveltejs/kit/pull/9351)) - fix: remove buggy cookie path detection ([#​9298](https://togithub.com/sveltejs/kit/pull/9298)) - fix: don't prevent `beforeNavigate` callbacks from running following a cancelled unloading navigation ([#​9347](https://togithub.com/sveltejs/kit/pull/9347)) - fix: persist DOM state on beforeunload ([#​9345](https://togithub.com/sveltejs/kit/pull/9345)) - fix: redirect to path with/without trailing slash when previewing prerendered pages ([#​9353](https://togithub.com/sveltejs/kit/pull/9353)) - fix: avoid FOUC when using CSS modules in dev ([#​9323](https://togithub.com/sveltejs/kit/pull/9323)) - fix: don't skip required parameters after missing optional parameters ([#​9331](https://togithub.com/sveltejs/kit/pull/9331)) - fix: account for server-emitted assets when prerenering ([#​9349](https://togithub.com/sveltejs/kit/pull/9349)) - fix: deal with fast consecutive promise resolutions when streaming ([#​9332](https://togithub.com/sveltejs/kit/pull/9332)) - chore: replace deprecated property access in preparation for TS 5.0 ([#​9361](https://togithub.com/sveltejs/kit/pull/9361)) ### [`v1.10.0`](https://togithub.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#1100) [Compare Source](https://togithub.com/sveltejs/kit/compare/@sveltejs/kit@1.9.3...@sveltejs/kit@1.10.0) ##### Minor Changes - feat: add `cookies.getAll` ([#​9287](https://togithub.com/sveltejs/kit/pull/9287)) ##### Patch Changes - fix: always include ``, even for stylesheets excluded from Link headers ([#​9255](https://togithub.com/sveltejs/kit/pull/9255)) - fix: preserve form state when submitting a second time ([#​9267](https://togithub.com/sveltejs/kit/pull/9267)) ### [`v1.9.3`](https://togithub.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#193) [Compare Source](https://togithub.com/sveltejs/kit/compare/@sveltejs/kit@1.9.2...@sveltejs/kit@1.9.3) ##### Patch Changes - fix: successive optional route parameters can now be empty ([#​9266](https://togithub.com/sveltejs/kit/pull/9266)) ### [`v1.9.2`](https://togithub.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#192) [Compare Source](https://togithub.com/sveltejs/kit/compare/@sveltejs/kit@1.9.1...@sveltejs/kit@1.9.2) ##### Patch Changes - fix: correct undefined reference to global var with Vitest ([#​9252](https://togithub.com/sveltejs/kit/pull/9252)) ### [`v1.9.1`](https://togithub.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#191) [Compare Source](https://togithub.com/sveltejs/kit/compare/@sveltejs/kit@1.9.0...@sveltejs/kit@1.9.1) ##### Patch Changes - feat: warn when calling depends(...) with special URI scheme ([#​9246](https://togithub.com/sveltejs/kit/pull/9246)) ### [`v1.9.0`](https://togithub.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#190) [Compare Source](https://togithub.com/sveltejs/kit/compare/@sveltejs/kit@1.8.8...@sveltejs/kit@1.9.0) ##### Minor Changes - feat: add `paths.relative` option to control interpretation of `paths.assets` and `paths.base` ([#​9220](https://togithub.com/sveltejs/kit/pull/9220)) ### [`v1.8.8`](https://togithub.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#188) [Compare Source](https://togithub.com/sveltejs/kit/compare/@sveltejs/kit@1.8.7...@sveltejs/kit@1.8.8) ##### Patch Changes - fix: always add `@sveltejs/kit` to `noExternal` for ssr build ([#​9242](https://togithub.com/sveltejs/kit/pull/9242)) - feat: add `api.methods` and `page.methods` to `builder.routes` ([#​9145](https://togithub.com/sveltejs/kit/pull/9145)) ### [`v1.8.7`](https://togithub.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#187) [Compare Source](https://togithub.com/sveltejs/kit/compare/@sveltejs/kit@1.8.6...@sveltejs/kit@1.8.7) ##### Patch Changes - fix: correct not found message when setting `paths.base` ([#​9232](https://togithub.com/sveltejs/kit/pull/9232)) ### [`v1.8.6`](https://togithub.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#186) [Compare Source](https://togithub.com/sveltejs/kit/compare/@sveltejs/kit@1.8.5...@sveltejs/kit@1.8.6) ##### Patch Changes - fix: bundle SvelteKit when using Vitest ([#​9172](https://togithub.com/sveltejs/kit/pull/9172)) ### [`v1.8.5`](https://togithub.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#185) [Compare Source](https://togithub.com/sveltejs/kit/compare/@sveltejs/kit@1.8.4...@sveltejs/kit@1.8.5) ##### Patch Changes - fix: allow relative fetch to endpoint outside app from within `handle` ([#​9198](https://togithub.com/sveltejs/kit/pull/9198)) ### [`v1.8.4`](https://togithub.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#184) [Compare Source](https://togithub.com/sveltejs/kit/compare/@sveltejs/kit@1.8.3...@sveltejs/kit@1.8.4) ##### Patch Changes - fix: include .mjs files in precompression ([#​9179](https://togithub.com/sveltejs/kit/pull/9179)) - fix: revert mjs extension usage by default, make it an option ([#​9179](https://togithub.com/sveltejs/kit/pull/9179)) - chore: dummy changeset to force a release ([#​9207](https://togithub.com/sveltejs/kit/pull/9207)) ### [`v1.8.3`](https://togithub.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#183) [Compare Source](https://togithub.com/sveltejs/kit/compare/@sveltejs/kit@1.8.2...@sveltejs/kit@1.8.3) ##### Patch Changes - fix: use a proprietary content-type to ensure response is not buffered ([#​9142](https://togithub.com/sveltejs/kit/pull/9142)) ### [`v1.8.2`](https://togithub.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#182) [Compare Source](https://togithub.com/sveltejs/kit/compare/@sveltejs/kit@1.8.1...@sveltejs/kit@1.8.2) ##### Patch Changes - fix: append newline to trigger script evaluation ([#​9139](https://togithub.com/sveltejs/kit/pull/9139)) ### [`v1.8.1`](https://togithub.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#181) [Compare Source](https://togithub.com/sveltejs/kit/compare/@sveltejs/kit@1.8.0...@sveltejs/kit@1.8.1) ##### Patch Changes - fix: encode streamed chunks ([#​9136](https://togithub.com/sveltejs/kit/pull/9136)) ### [`v1.8.0`](https://togithub.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#180) [Compare Source](https://togithub.com/sveltejs/kit/compare/@sveltejs/kit@1.7.2...@sveltejs/kit@1.8.0) ##### Minor Changes - feat: implement streaming promises for server load functions ([#​8901](https://togithub.com/sveltejs/kit/pull/8901)) ##### Patch Changes - fix: set public env before starting app ([#​8957](https://togithub.com/sveltejs/kit/pull/8957)) - fix: preload modules on Safari ([#​8957](https://togithub.com/sveltejs/kit/pull/8957)) - fix: make `assets` work in client when app is served from a subfolder ([#​8957](https://togithub.com/sveltejs/kit/pull/8957)) ### [`v1.7.2`](https://togithub.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#172) [Compare Source](https://togithub.com/sveltejs/kit/compare/@sveltejs/kit@1.7.1...@sveltejs/kit@1.7.2) ##### Patch Changes - fix: return correct asset list from `builder.writeClient()` ([#​9095](https://togithub.com/sveltejs/kit/pull/9095)) ### [`v1.7.1`](https://togithub.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#171) [Compare Source](https://togithub.com/sveltejs/kit/compare/@sveltejs/kit@1.7.0...@sveltejs/kit@1.7.1) ##### Patch Changes - fix: deploy server assets. Only works with Vite 4.1+ ([#​9073](https://togithub.com/sveltejs/kit/pull/9073)) ### [`v1.7.0`](https://togithub.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#170) ##### Minor Changes - feat: richer error message for invalid exports ([#​9055](https://togithub.com/sveltejs/kit/pull/9055)) ##### Patch Changes - chore: throw more helpful error when encoding uri fails during prerendering ([#​9053](https://togithub.com/sveltejs/kit/pull/9053)) ### [`v1.6.0`](https://togithub.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#160) ##### Minor Changes - feat: add `OPTIONS` server method ([#​8731](https://togithub.com/sveltejs/kit/pull/8731)) ##### Patch Changes - fix: solve `missing "./paths" specifier in "@​sveltejs/kit" package` error occurring in all projects ([#​9050](https://togithub.com/sveltejs/kit/pull/9050)) ### [`v1.5.7`](https://togithub.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#157) ##### Patch Changes - fix: use internal alias that won't collide with user aliases ([#​9022](https://togithub.com/sveltejs/kit/pull/9022)) ### [`v1.5.6`](https://togithub.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#156) ##### Patch Changes - fix: ssr defaults preventing minification for client build ([#​9012](https://togithub.com/sveltejs/kit/pull/9012)) - fix: client-side trailing slash redirect when preloading data ([#​8982](https://togithub.com/sveltejs/kit/pull/8982)) ### [`v1.5.5`](https://togithub.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#155) [Compare Source](https://togithub.com/sveltejs/kit/compare/@sveltejs/kit@1.5.3...@sveltejs/kit@1.5.5) ##### Patch Changes - fix: warn after failed data preloads in dev ([#​8985](https://togithub.com/sveltejs/kit/pull/8985)) ### [`v1.5.3`](https://togithub.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#153) [Compare Source](https://togithub.com/sveltejs/kit/compare/@sveltejs/kit@1.5.2...@sveltejs/kit@1.5.3) ##### Patch Changes - docs: clarify that `version.name` should be deterministic ([#​8956](https://togithub.com/sveltejs/kit/pull/8956)) - fix: correctly include exported http methods in allow header ([#​8968](https://togithub.com/sveltejs/kit/pull/8968)) - chore: polyfill File from node:buffer ([#​8925](https://togithub.com/sveltejs/kit/pull/8925)) - fix: provide helpful error/warning when calling `fetch` during render ([#​8551](https://togithub.com/sveltejs/kit/pull/8551)) - fix: print useful error when subscribing to SvelteKit's stores at the wrong time during SSR ([#​8960](https://togithub.com/sveltejs/kit/pull/8960)) - fix: ignore external links when automatically preloading ([#​8961](https://togithub.com/sveltejs/kit/pull/8961)) - chore: refactor fallback generation ([#​8972](https://togithub.com/sveltejs/kit/pull/8972)) ### [`v1.5.2`](https://togithub.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#152) [Compare Source](https://togithub.com/sveltejs/kit/compare/@sveltejs/kit@1.5.1...@sveltejs/kit@1.5.2) ##### Patch Changes - fix: always default `paths.assets` to `paths.base` ([#​8928](https://togithub.com/sveltejs/kit/pull/8928)) ### [`v1.5.1`](https://togithub.com/sveltejs/kit/blob/HEAD/packages/kit/CHANGELOG.md#151) [Compare Source](https://togithub.com/sveltejs/kit/compare/@sveltejs/kit@1.5.0...@sveltejs/kit@1.5.1) ##### Patch Changes - fix: pick up config from endpoints ([#​8933](https://togithub.com/sveltejs/kit/pull/8933)) - fix: don't reuse previous server load cache when there's no server load function ([#​8893](https://togithub.com/sveltejs/kit/pull/8893)) - fix: deduplicate paths in tsconfig ([#​8880](https://togithub.com/sveltejs/kit/pull/8880)) - docs: clarify version management feature ([#​8941](https://togithub.com/sveltejs/kit/pull/8941))

Configuration

📅 Schedule: Branch creation - "" in timezone America/Phoenix, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

This PR has been generated by Renovate Bot.