search

marcusvolz / strava

Create artistic visualisations with your exercise data
Other
520 stars 57 forks source link

Add plot ridge #23

Closed mihagazvoda closed 4 years ago

mihagazvoda commented 4 years ago

Hi, I love the package! I added plot_ridges function and fixed packages imports and depends so there's no need for additional package imports.

marcusvolz commented 4 years ago

Thanks Miha and Hugo!

hugovk commented 4 years ago

Would also be great to see some examples in the README!

mihagazvoda commented 4 years ago

Agree! An example would be great because it can also be used for unit tests. I'm not sure where to get the data (don't want to use my personal). Any ideas? I also plan to give a shot to add_calendar function and maybe refactor others.

On Mon, 25 May 2020 at 10:31, Hugo van Kemenade notifications@github.com wrote:

Would also be great to see some examples in the README!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/marcusvolz/strava/pull/23#issuecomment-633450706, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACTTDRLBCNM77UTBABFVZN3RTIUGHANCNFSM4NI36ENA .