search

marcusvolz / strava

Create artistic visualisations with your exercise data
Other
520 stars 57 forks source link

Expanded functionality #52

Closed Vosbrucke closed 2 years ago

Vosbrucke commented 2 years ago

Hi, I created some new functions to the package. Most of them are based on activities.csv file but there are also some changes to already existing functions. At first I started with the idea to implement colors by activity type in plot_facets and then to explore further possibilities with the data. Bear in mind that I heard about R only a couple months ago so there may be some things which could have been made much easier and faster. Please, feel free to make or suggest changes.

hugovk commented 2 years ago

Please could you remove the .DS_Store files, and list .DS_Store in .gitignore?

Vosbrucke commented 2 years ago

I changed it. Is it ok now?

hugovk commented 2 years ago

Thanks! I'll let others who are more familiar with R review the actual code.

marcusvolz commented 2 years ago

I will review on the weekend, thank you!

marcusvolz commented 2 years ago

@Vosbrucke Thank you for the new visualizations and updates to existing visualizations, they look great!

I have reviewed the code briefly and it looks good to me, although I have not had a chance yet to create the plots with my own data.

I note that a Google Maps API key is required to create the individual plot map. Perhaps you could add to the readme user instructions on how to do this.

@datawookie @mihagazvoda If either of you have time and would be interested to review this PR it would be appreciated! Otherwise I'm happy to merge.

Vosbrucke commented 2 years ago

@marcusvolz Thanks for the response.

You are right about the API key. I have made changes to README file where I added info on how to access Google API key and what possibilities functions dependent on the output of process_activities have.

I am also thinking about providing example data but this is something I will do in the future.