Cyclemeter Support - Githubissues

marcusvolz / strava_py

Create artistic visualisations with your exercise data (Python version)

MIT License

152 stars 18 forks source link

Cyclemeter Support #37

Open wiredfool opened 11 months ago

wiredfool commented 11 months ago

Cyclemeter stores similar data to Strava -- at least, you can download a sqlite db of all the activity data stored in your personal iCloud instance.

This is a draft PR to provide basic support to pull data from that sqlitedb and run the same visualizations as from Strava. Not sure if this makes sense as an addition to this project or a fork. Your call on that one.

Some caveats:

Tests aren't implemented, as I'd have to anonymize a cyclemeter db to do that.
It yields gigantic images so perhaps it would make sense on some of these to push down the year selectors to the mapping functions. Thousands of workouts are rather slow.

marcusvolz commented 11 months ago

Thank you @wiredfool - this looks good to me (adds support for Cyclemeter db files). I've not used Cyclemeter before, so I don't have any files to test. @hugovk are you happy with the changes or do you have any thoughts? Please feel free to merge if you are happy.

hugovk commented 11 months ago

Hi Eric!

I'm fine with the changes (once the linter is appeased), it would be nice to add a test database to make sure the code runs properly.

Can we create one with the GPX files in https://github.com/marcusvolz/strava_py/tree/main/tests/gpx? We don't have unit tests (yet?) but there's some sanity test runs in tox.ini.

Linter:

$ pip install pre-commit; pre-commit run --all-files

$ # or

$ pip install black isort flake8; black .; isort .; flake8