marcuswestin / store.js

Cross-browser storage for all use cases, used across the web.
MIT License
14.02k stars 1.33k forks source link

Add command for new release #218

Closed jrbotros closed 7 years ago

jrbotros commented 7 years ago

Here's a first stab at #199 using npm version. Wasn’t sure if I should add a command to the Makefile or if running npm version patch/minor/major && npm publish was good enough (since passing the patch/minor/major arg to a make command is a bit of a pain). I also updated store-engine.js to import the version string from package.json, but if there’s a good reason for keeping it in two places I’m happy to retool my PR a bit!

marcuswestin commented 7 years ago

Hey, this is great - thanks! Sorry for the long delay in reacting.

This patch ends up including all of package.json in every build/release. How do you feel about that?

jrbotros commented 7 years ago

Ah, sorry for the delay in responding! I think that should be fine—happy to see it merged 😊

marcuswestin commented 7 years ago

Thanks @jrbotros!