search

marcuswestin / store.js

Cross-browser storage for all use cases, used across the web.
MIT License
14.01k stars 1.33k forks source link

What does "modern browsers" mean? #219

Open paulfalgout opened 7 years ago

paulfalgout commented 7 years ago

I've been trying to find out how this lib defines modern browsers.
At first glance it looks like modern supports IE8+ and legacy is prior to IE8?

If that's the case, it seems like this library could very safely have the default script in package.json be the modern build.

shelldandy commented 7 years ago

well modern will most likely at least mean: latest version 😄

paulfalgout commented 7 years ago

I think in the case of this library it also means really old browsers most people don't support anymore. And legacy means prior to that.

Sembiance commented 6 years ago

I'm also wondering specifically which browsers are supported by the 'modern' version.

IE8? IE9?

shelldandy commented 6 years ago

IE11 + ??

shelldandy commented 6 years ago

Actually its right on the readme

Tested on IE6+ Tested on iOS 8+ Tested on Android 4+ Tested on Firefox 4+ Tested on Chrome 27+ Tested on Safari 5+ Tested on Opera 11+ Tested on Node (with https://github.com/coolaj86/node-localStorage)

Sembiance commented 6 years ago

@mike3run I believe the browsers listed in the readme are for the "legacy" version which has wider support and not the "modern" dist.

shelldandy commented 6 years ago

True, well reading the sourcecode for like 2 seconds I noted there are 2 files that start with old

https://github.com/marcuswestin/store.js/tree/master/storages

Old IE means 6 and 7 Old FF means 6 and 7 as well

So modern browsers would then mean:

Tested on IE8+ Tested on iOS 8+ Tested on Android 4+ Tested on Firefox 8+ Tested on Chrome 27+ Tested on Safari 5+ Tested on Opera 11+ Tested on Node (with https://github.com/coolaj86/node-localStorage)