Closed michael-bouvy closed 7 years ago
I see. So you're saying that storage should change on a per-key basis?
Won't it be confusing if you store one key that does persist between page loads, and another key that doesn't (when the only difference between the two is the size of the value stores)?
I'm thinking that the storage should instead throw if a value exceeds storage limits.
It would indeed be confusing. Is it possible to disable a specific storage? Thanks!
You can create a custom build which only includes the storages you want to use: https://github.com/marcuswestin/store.js/blob/master/README.md#user-content-make-your-own-build On Tue, Mar 14, 2017 at 1:37 PM Michael Bouvy notifications@github.com wrote:
It would indeed be confusing. Is it possible to disable a specific storage? Thanks!
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/marcuswestin/store.js/issues/221#issuecomment-286500447, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIDf82BGr2TFJ_V4iTvRH1ZmrTMem4Pks5rltBAgaJpZM4Mc1ah .
Ok, I will do this. Thanks again Marcus!
First of all thanks for the great work, this lib is very useful!
Method used to reproduce the bug in a clean Safari (10.0.2 / macOS Sierra) private mode window:
Expected behaviour is use of memory storage when localStorage and cookie are not sufficient.
Running browser cookie limit test at http://browsercookielimits.squawky.net/ gives 4097 bytes as limit per cookie.