search

marcuswestin / store.js

Cross-browser storage for all use cases, used across the web.
MIT License
14.01k stars 1.33k forks source link

2.0.8 - No supported storage has been added #236

Closed stunaz closed 7 years ago

stunaz commented 7 years ago

After upgrading from 2.0.4 to2.0.8, i got this error:

Error: store.js: No supported storage has been added! Add one (e.g store.createStore(require('store/storages/cookieStorage')) or use a build with more built-in storages (e.g https://github.com/marcuswestin/store.js/tree/master/dist/store.legacy.min.js)

marcuswestin commented 7 years ago

Shoot! Can you give me more info on how you include store.js in your app (or create the store)?

marcuswestin commented 7 years ago

I'm trying to reproduce this and not having any luck.

stunaz commented 7 years ago 
import store from 'store';
const token = store.get('token'); // or set ...

never had to specified a storage or anything else

stunaz commented 7 years ago

Reverted to 2.0.4, and it is working again

marcuswestin commented 7 years ago

Bizarre. Thanks. What's the environment you're testing in? (e.g browser version)

stunaz commented 7 years ago

browser chrome Version 58.0.3029.110 (64-bit)

marcuswestin commented 7 years ago

Ok, got repro. Will fix asap

stunaz commented 7 years ago

Thanks

marcuswestin commented 7 years ago

This is a really silly bug. I'm amazed that none of the tests covered it. Sorry for the hassle :/

stunaz commented 7 years ago

no worries, wondering why I am the first to notice... maybe I should have customized the store creation ... like obviously everybody :-)

marcuswestin commented 7 years ago

It's only been out for a few hours - that may be why :) Ok, v2.0.9 has been released.

marcuswestin commented 7 years ago

Thanks for prompt responses @stunaz! Going back to bed :)

stunaz commented 7 years ago

worked, thanks