Open facebook event in new window/tab

marcuswestin / store.js

Cross-browser storage for all use cases, used across the web.

MIT License

14.02k stars 1.33k forks source link

Open facebook event in new window/tab #294

Closed briggySmalls closed 5 years ago

briggySmalls commented 5 years ago

The location link from an event page uses the target="_blank" attribute to open in a new tab/window.

However the facebook event page doesn't do the same.

My instinct is that external links should open in a new tab/window, and internal links should move the page, but css tricks claim otherwise.

It does feel like this content is supplementary rather than a replacement/moving on. Although perhaps the facebook qualifies for this statement less than the google maps location does.

briggySmalls commented 5 years ago

Blimey, I'm really sorry. Wrote a complete issue in the wrong repo. Clearly haven't woken up properly yet 🙇‍♂️