Closed mshodge closed 6 years ago
@mshodge Thanks very much for the pull request and interest in the project. Because your changes are on the old R script that I originally wrote for my research, I won't accept the pull request. We now have functions being written within the R package structure. There should be a commit fairly soon with a range of those functions (including, for example, one that also returns route geometry). What I will do is review the work you have done and incorporate your suggestions into the relevant functions as appropriate. I have no problem with you using my original code in the meantime. Once again, thanks for the useful input.
Changes from the Data Science Campus, including:
We have tested this on our own unit tests and each function passed:
These changes were made to develop a series of R scripts for certain tasks required at the Data Science Campus. If the changes are not passable (rejected) please allow us to use your original code with acknowledgements. If the changes are accepted, we will import the package into our work (again, with acknowledgements).