search

marcusyoung / opentripplanner

An API wrapper for OpenTripPlanner (OTP) as an R package
11 stars 5 forks source link

Update package #17

Closed Robinlovelace closed 6 years ago

Robinlovelace commented 6 years ago

Heads-up @marcusyoung this is the result of our minihack. It is a working (passing CRAN tests and with continuous integration on Travis) package that contains many of the key changes introduced by @mem48 but without the huge pkg size (note the data has been uploaded as a .zip in the releases on your branch) and with a few other fixes thanks to awesome input from @layik.

marcusyoung commented 6 years ago

@Robinlovelace Great stuff. I'll take a look and all being well, merge.

marcusyoung commented 6 years ago

@Robinlovelace @mem48 @layik Ok I'm going to merge this to master. Thanks for all the great work on this. Have made one comment regarding format for date but not critical. I also think long term otp_plan_batch probably isn't the right approach. I think "batch" should be an option for all relevant functions - i.e. you should be able to provide either a single OD pair or a matrix to otp_plan etc.