WIP Fixes for mdx-deck 3

marcysutton / js-a11y-workshop

Frontend Masters Workshop: Accessibility in JavaScript Applications

https://frontendmasters.com/courses/javascript-accessibility/

MIT License

229 stars 95 forks source link

WIP Fixes for mdx-deck 3 #2

Closed jxnblk closed 5 years ago

jxnblk commented 5 years ago

It looked like gatsby-plugin-mdx might've been failing silently with some of the syntax in the MDX file, and gatsby-theme-mdx-deck was not properly handling pathPrefix – PR here

Updates imports based on where I think the modules are located (I might've mixed something up here)
Removes JS comments from MDX – AFAIK comments that start with // are not supported in MDX
Exports JS functions from MDX - without export at the beginning of the line, I don't think MDX parses that as JS

marcysutton commented 5 years ago

Thank you so much! I didn't realize there was a PR before I fixed some of those path issues myself...lots of late nights around here as writing material and switching platforms was a bit ambitious 😅

I think I've got it sorted out now, so I'm going to close this. But I really, really appreciate your help on this!