search

marczoutendijk / openpoimap

version 1.29d
33 stars 12 forks source link

Bump JS version #8

Closed bonanza123 closed 6 years ago

bonanza123 commented 6 years ago

All version <3.30 are deprecated https://developers.google.com/maps/documentation/javascript/versions

Fixes a google api error

@marczoutendijk I think there is nevertheless something wrong: E.g. searching for "parking" in berlin does not show any results (and there is also no corresponding error in the browser console)

marczoutendijk commented 6 years ago

In the current version (1.28) there seems to be a problem anyway, because none of the available pois in the menus seem to work at all! Will check this later today.

bonanza123 commented 6 years ago

@marczoutendijk thanks for the update. For me, firefox reports the following error Google Maps API warning: NoApiKeys https://developers.google.com/maps/documentation/javascript/error-messages#no-api-keys and there no POIs shown yet.

marczoutendijk commented 6 years ago

Op 1 mei 2018, om 17:53 heeft bonanza123 notifications@github.com het volgende geschreven:

@marczoutendijk https://github.com/marczoutendijk thanks for the update. For me, firefox reports the following error Google Maps API warning: NoApiKeys https://developers.google.com/maps/documentation/javascript/error-messages#no-api-keys and there no POIs shown yet.

—

The google-link is only there to make is possible for users (once they have a poi on their screen visible) to show that location on google. It is not used at all for finding the pois in the first placem because that is done with overpassturbo.

But is seems that something else is broken too!

I’m working on it.

Marc.

marczoutendijk commented 6 years ago

Hi,

Op 1 mei 2018, om 17:53 heeft bonanza123 notifications@github.com het volgende geschreven:

@marczoutendijk https://github.com/marczoutendijk thanks for the update. For me, firefox reports the following error Google Maps API warning: NoApiKeys https://developers.google.com/maps/documentation/javascript/error-messages#no-api-keys and there no POIs shown yet.

I just released a new version (1.29a) that fixes an overpass call bug. Everything seems to be working again now.

Marc.

bonanza123 commented 6 years ago

@marczoutendijk Great, thank you very much!