Closed powellchristoph closed 9 years ago
I will be opening a bug with PyPi also. Should package names be normalized in the database? Eg, downcased and '-' converted to '_' ?
FYI, I found the commits to PyPi that broke the RPC search function. https://bitbucket.org/pypa/pypi/commits/43471d1062ac47bc57809c0280316503a6d2a00b
It appears that they pushed out using Eleasticsearch for their searching. https://bitbucket.org/pypa/pypi/commits/all
should be fixed by https://github.com/mardiros/pyshop/pull/56
Wow, thanks for the quick response!
@powellchristoph
I have tested before applying the patch of @brmzkw but I don't see any problem (using postgresql)
Did you test the patch ? does it works for you ? Does PyPI has fixed the problem on their side ?
@brmzkw
I have applyied the patch a bit quick but don't see the point. What is the relation between the _search_package method and by_name ?
PyPI has applied a fix. https://bitbucket.org/pypa/pypi/issue/286/search-functionality-broken
I will test the patch shortly.
OK thanks for the feedback
What is the relation between the _search_package method and by_name
I thought it was related. My bad, my fix fixed something else :)
Last night, it appears that PyPi might have made a change to their search functionality. Several packages that have been installed 8,700 times or more are suddenly breaking and it is because they are no longer being returned in the _search_package function.
It appears to me that packages that include uppercase characters are being downcased by pip. Pyshop cannot make a match because the package names are stored as camel-case and so pyshop searches PyPi for a match and then uses that to find the package. But since PyPi's search is broken, its not returning any results which mean pyshop returns package not found.
Case in point, Babel and MarkupSafe.
If you search for babel on PyPi, it returns no results on their webpage or in pyshop's search_results. But the package is listed in /simple and you can navigate to them.
I added some debug lines.
Search for markupsafe, PyPi shows a match but Pyshop doesnt list any.
Here is the output for Babel yesterday. It finds the package and lists the versions.
I would be happy to work on this with you as I need a fix asap. My CICD pipeline is down and therefore my shop until this is resolved.