mareinc / mare

The website for the Massachusetts Adoption Resource Exchange
MIT License
4 stars 2 forks source link

Update registered child's record #392

Closed n-devr closed 4 years ago

n-devr commented 5 years ago

Select an already registered child's form to provide an update to that record. Submission of this form will result in an email sent. All fields should be available to update, but is it possible to highlight: Where does this child presently live? City of Location Name of Group Home/Residential Legal Status All 4 Needs Text Boxes All of the Interests, School, Family, etc. Text Boxes

bchiaruttini commented 5 years ago

email generated should be sent to staff contact for Child Registration Form

n-devr commented 4 years ago

Additional tasks per conversation with @bchiaruttini :

n-devr commented 4 years ago

I'm working on building out the email notification functionality and I have a quick question about the email template - is there any other content that needs to be added to the email template? My plan is to just copy the new social worker child registration template and update the language to describe the edit action.

@bchiaruttini let me know what you'd prefer!

bchiaruttini commented 4 years ago

@n-devr, no there is no additional information needed. The priority is to make it clear it is an update (versus new registration) in any heading, title, etc. so that it is easily identifiable. And it should be sent to the same staff contact as social worker child registration forms. thanks.

n-devr commented 4 years ago

@bchiaruttini the update record form and email functionality is ready for testing in development. I created a temporary staff email target for testing purposes, so any update requests will be sent to your MARE email address so you can review the emails as well. Once we are satisfied with the flow I will set the email target to the social worker child registration staff contact before we deploy to production.

This ended up being quite a complex task that required a lot of special-cases and workarounds, so I expect that there may be some additional adjustments we need to make before it's ready to be released. Please let me know if you see any issues during your testing!

bchiaruttini commented 4 years ago

@n-devr I tested this out and let's review this morning.

n-devr commented 4 years ago

Per review with @bchiaruttini there are a few more small changes to be made:

Let me know if I missed or misrepresented anything!

bchiaruttini commented 4 years ago

@n-devr In testing this, when I submit any change to a child update form, I get a pink error message: There was an error editing this child registration. If this error persists, please notify MARE at communications@mareinc.org

I did not get the same error when creating a new child record (although didn't get confirmation email so maybe these need to be turned back on to test?) thanks.

n-devr commented 4 years ago

@bchiaruttini were you testing in development or production? I did reset all of the email toggles in development so it won't send any emails by design, but I can update it so the email will be sent again if you'd like to run through it.

Also the staff contact for child registration emails is Kimberly Sheppard in production, so the emails will be sent to her if they are being generated.

bchiaruttini commented 4 years ago

@n-devr I was testing in development, correct? I just tried again and got the same error message when attempting to submit an update to an existing record.

n-devr commented 4 years ago

@bchiaruttini I turned off the sending of emails in development after we did our initial testing - that's the default state for all email actions in development. I can turn them back on, I just need to update some environment variables and redeploy the app in order to do so. I'm happy to do so whenever, just let me know when you'd like to test and I can toggle/redeploy and let you know when it's ready.

bchiaruttini commented 4 years ago

@n-devr I'm free now if a good time to test?

But I am not sure that this is the issue with the error message. B/c when I submitted a new child registration I did not get the error (even though emails were off), but when I submitted an update I got the error message?

n-devr commented 4 years ago

Sorry @bchiaruttini I didn't see the notification that you were free to test. I updated the environment variables in development so you can test whenever you have time tomorrow - the email for child registration and edit should come to you. Let me know once you're done testing and I'll toggle the emails off again.

bchiaruttini commented 4 years ago

@n-devr tested out and changes all look good and ready to push. Pls toggle off emails as well.

n-devr commented 4 years ago

Sounds good - email flag is toggled and development is rebuilding now.

bchiaruttini commented 4 years ago

@n-devr Sorry to hear you are not well today, and this can wait until your feeling better! But I am concerned that this code was not pushed to production. When logged into production currently as a SW I only have the option to Register a Child, not update or work off a sibling that is already registered. This looks correct in development (screenshot.) image

bchiaruttini commented 4 years ago

p.s. we have rec'd updates so this was working correctly at some point.

n-devr commented 4 years ago

Thanks @bchiaruttini - getting to rest today has already some good!

Does the SW account that you're logged in with have any children? The update functionality is designed not display unless the SW has children to update.

bchiaruttini commented 4 years ago

@n-devr Ahhh, yes that is the issue, makes sense. thanks.