Closed remmel closed 1 year ago
Hi and thanks for your contributions :)!
I've just merged your PR #4 for URL video source. I wanted to add URL video source and also a YouTube video source for some time, but I couldn't get to it yet, so I appreciate your work.
Feel free to push the second PR (es6 version). There are a few minor issues in the es6 branch related mainly to WiFi streaming, but otherwise I also think it's OK.
List of things to fix in the es6 version:
WiFiStreamedVideoSource
import {WiFiStreamedVideoSource} from "./js/app/video-sources/WiFiStreamedVideoSource.js";
export
the getMetadata()
function
export function getMetadata(serverURL)
import
missing pieces from SignalingClient
import {Record3DSignalingClient, getMetadata} from "./SignalingClient.js";
I'm not sure if it's just me or if you noticed this too, but when I tried the es6 version, my browser kept waiting quite a long time for unpkg.com
. I'll test with other CDNs.
Thanks for you feedbacks, I forgot to test the wifi feature... added it in my fork. I'll try to push that thoses days. https://github.com/remmel/record3d-wifi-streaming-and-rgbd-mp4-3d-video-demo/tree/es6
About unpkg.com I also had the same feeling (probably for other libs on other project). FYI threejs is also using it https://threejs.org/docs/index.html#manual/en/introduction/Installation
Agree, fetching https://unpkg.com/three@0.147.0/examples/jsm/libs/lil-gui.module.min.js takes ~30s (but when you reload right after, it seems to be cached) - changing cdn or using https://www.npmjs.com/package/lil-gui could be a good idea... or waiting that something being fixed on unpkg server (it's look more of a unpkg problem)
Thanks for including the fixes. I think the issue with delay on unpkg's servers has been fixed, lil-gui
loads almost immediately for me now (even when downloading with wget
), but let's keep jsdelivr for now. The es6 PR has been merged.
Great!
Hi thanks for your application :)
Because I'ld like to use your rgbd format in my project https://www.metalograms.com/demo
I want to push 2 PRs: