search

marek-simonik / record3d-wifi-streaming-and-rgbd-mp4-3d-video-demo

MIT License
29 stars 7 forks source link

Add Url video support and demo button #4

Closed remmel closed 1 year ago

remmel commented 1 year ago

Make easily to watch the example handling url video, adding the video on the repo and having a demo/example button (#demo)

Part 1. of https://github.com/marek-simonik/record3d-wifi-streaming-and-rgbd-mp4-3d-video-demo/issues/3

(introduced duplicated code to parse metadata might be remove in 2.)

remmel commented 1 year ago

Or should I merge OfflineVideoSource and UrlVideoSource classes ? and check the mp4 file type (File or String=> url)

marek-simonik commented 1 year ago

I like the idea of keeping OfflineVideoSource and UrlVideoSource in separate classes better (there might be significant differences in metadata parsing logic in the future). As you wrote, the metadata parser logic could be extracted into a function/class later, in the es6 version.