search

marek5050 / UN-Locode-with-Timezone

UN Locodes with additional lat, long, and timezone information
7 stars 2 forks source link

Unbalanced quote for BRSSA entry #3

Open nt-gt opened 2 years ago

nt-gt commented 2 years ago

Hi,

In https://raw.githubusercontent.com/marek5050/UN-Locode-with-Timezone/master/data/easy_allCountries.csv, the following line has a unbalanced quote (the trailing " in Salvador International Airport"):

Salvador,BR,BA,BRSSA,SSA,Salvador International Airport", Deputado Luis Eduardo Magalhaes,,-12.9110,-38.3310,America/Bahia,2013-11-17

This confuses CSV parsers, so I was hoping it could be fixed. :)

nt-gt commented 2 years ago

Looking at the original data set (allCountries.txt), there is no misplaced quotes for anything matching Salvador International Airport and I do not see a quote for BR,SSA in https://raw.githubusercontent.com/marek5050/UN-LOCODE/master/data/code-list.csv either.

$ grep "Salvador International Airport" allCountries.txt
6300674 Salvador International Airport, Deputado Luís Eduardo Magalhães Salvador International Airport, Deputado Luis Eduardo Magalhaes                                    Aeroporto Dois de Julho,Aeroporto Internacional de Salvador,Aeroporto Internacional de Salvador Deputado Luis Eduardo Magalhaes,Aeroporto Internacional de Salvador Deputado Luís Eduardo Magalhães,Deputado Luis Eduardo Magalhaes International Airport,Deputado Luís Eduardo Magalhães International Airport,Dois de Julho International Airport,SBSV,SSA,Salvador International Airport      -12.91099       -38.33104       S       AIRP    BR              05      2927408        0       19      9       America/Bahia   2013-11-17
3810409 Aeropuerto Internacional El Salvador    Aeropuerto Internacional El Salvador    Aeroport international de San Salvador,Aeropuerto Internacional de El Salvador,Aéroport international de San Salvador,Comalapa International Airport,Cuscatlan International Airport,Cuscatlán International Airport,El Salvador International Airport,MSLP,SAL,elsalbadoleu gugjegonghang,erusarubadoru guo ji kong gang,frwdgah byn‌almlly alsalwadwr,فرودگاه بین‌المللی السالوادور,エルサルバドル国際空港,엘살바도르 국제공항           13.44095 -89.05573       S       AIRP    SV              06                              0       30      32      America/El_Salvador                                        2013-12-15

My best bet is that the code https://github.com/marek5050/UN-Locode-with-Timezone/blob/ebfb2d90209ea48487b1cb3784baf92a59c79d52/scripts/grab_latest.py introduces it somehow, but I do not see anything obvious in that script.

marek5050 commented 2 years ago

Hello @nt-as ,

Woah! this data was supposed to be automatically generated every month :D how come the cron job stopped working?

Will look into the extra double quote issue over the weekend.

Thanks a bunch for letting me know.