search

marekrei / encode-explorer

http://encode-explorer.siineiolekala.net
236 stars 120 forks source link

[feature] Allow to use own cdn or include jquery file #77

Open Shnoulle opened 4 years ago

Shnoulle commented 4 years ago

Currntly : there are a call to ajax.googleapis.com for jquery. Some user disable all google call and then they can not have the working JS

2 solutions

  1. Add jquery (min) file in the repo
  2. Create a $_CONFIG to load another cdn (can be an user link)
marekrei commented 4 years ago

I think most users would prefer to link the public javascript file. Those who want to use their own can just change the URL on line 2969. I don't think it's enough of a common case to create a separate config option.

Merith-TK commented 4 years ago

I personally just wget the js file, and stored it on my server and then changed the link

So basically i hid the cdn.example.com/.js folder, and changed the path to the js file to cdn.example.com/.js/jquery.min.js

Shnoulle commented 4 years ago

I update too the url : i's easy :). But maybe it can be easiest to have a $_CONFIG then ?