Possible wrong lowercase flag is passed?

marekrei / sequence-labeler

Neural network sequence labeling model

252 stars 74 forks source link

Possible wrong lowercase flag is passed? #7

Closed kmkurn closed 6 years ago

kmkurn commented 6 years ago

Hi,

Did you mean to pass lowercase_chars flag when building characters vocabulary here?

https://github.com/marekrei/sequence-labeler/blob/484a6beb1e2a2cccaac74ce717b1ee30c79fc8d8/sequence_labeling_experiment.py#L285

marekrei commented 6 years ago

Indeed, thanks for catching that! I've actually created a new version that removes the option of lowercasing characters, as that's not really needed. Will update soon.