search

marekrozmus / react-swipeable-list

Swipeable list component for React supporting several behaviours (e.g. iOS)
https://marekrozmus.github.io/react-swipeable-list/
MIT License
114 stars 20 forks source link

Update SwipeableListItemProps #19

Closed harrisgca closed 2 years ago

harrisgca commented 2 years ago

  1. onSwipeProgress: The README lists progress as the prop being passed to the callback, but the type does not include the parameter, which causes a Typescript error. Screen Shot 2022-01-31 at 8 22 05 PM Screen Shot 2022-01-31 at 8 23 31 PM

  2. className: This code block shows className as an accepted prop (https://github.com/marekrozmus/react-swipeable-list/blob/main/src/SwipeableListItem.js#L768-L773), but needs to be added to the types to avoid a TS error

Screen Shot 2022-01-31 at 8 29 41 PM

codecov-commenter commented 2 years ago

Codecov Report

Merging #19 (2ecda89) into main (5871316) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #19   +/-   ##
=======================================
  Coverage   90.41%   90.41%           
=======================================
  Files           5        5           
  Lines         438      438           
  Branches      161      161           
=======================================
  Hits          396      396           
  Misses         42       42

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5871316...2ecda89. Read the comment docs.

marekrozmus commented 2 years ago

@all-contributors please add @harrisgca for maintenance

allcontributors[bot] commented 2 years ago

@marekrozmus

I've put up a pull request to add @harrisgca! :tada:

marekrozmus commented 2 years ago

@harrisgca thank you 🥇 🙂