search

marekrozmus / react-swipeable-list

Swipeable list component for React supporting several behaviours (e.g. iOS)
https://marekrozmus.github.io/react-swipeable-list/
MIT License
110 stars 20 forks source link

maxSwipe is not optional #50

Closed RaulEscobarRivas closed 10 months ago

RaulEscobarRivas commented 1 year ago

Describe the bug maxSwipe prop is not optional

https://github.com/marekrozmus/react-swipeable-list/blob/main/src/module.d.ts#L180

To Reproduce

  1. install latest
  2. try to use the SwipeableListItem component without passing maxSwipe prop

Expected behavior Prop should be optional as per the docs

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

marekrozmus commented 10 months ago

@all-contributors please add @RaulEscobarRivas for bug

allcontributors[bot] commented 10 months ago

@marekrozmus

I've put up a pull request to add @RaulEscobarRivas! :tada:

marekrozmus commented 10 months ago

@RaulEscobarRivas Fixed in 1.9.2

RaulEscobarRivas commented 10 months ago

thank you @marekrozmus !