marellocommerce / marello

Marello
Other
51 stars 18 forks source link

Localized mail aren't sent: Function does not exist anymore #61

Closed clicktrend closed 4 years ago

clicktrend commented 4 years ago

https://github.com/marellocommerce/marello/blob/1999cc10e65e8f726b9b8d4ea5a2ba57c2fe7061/src/Marello/Bundle/LocaleBundle/Manager/EmailTemplateManager.php#L78

Use Oro\Bundle\EmailBundle\Provider\EmailTemplateContentProvider::getTemplateContent(EmailTemplateCriteria $criteria, Localization $localization, array $templateParams) instead

24198 commented 4 years ago

Hi @clicktrend,

Can you please verify the versions of Marello and Oro Platform (Marello 3.0 should be running Platform 4.1.0 or higher), as this function does exist in Oro Platform 4.1.x. We have changed this as the previous function we used was removed from the Platform.

Kind Regards,

Jaimy

clicktrend commented 4 years ago

I'm using Marello 3.0 and function "findWithLocalizations" still exists but without the second parameter!

24198 commented 4 years ago

Hi @clicktrend,

Thanks for the fast response, we are investigating the issue and have marked it as a bug for now. We will include a fix in the next release. Thanks for reporting!

Kind Regards,

Jaimy

24198 commented 4 years ago

Hi @clicktrend,

The issue has been fixed in the 3.0.1 release. This will allow you to use the localization for notifications as intented.

Kind Regards,

Jaimy