search

mareyc / homework-portfolio

0 stars 0 forks source link

Feedback for assignment #1 #1

Open barryross opened 8 years ago

barryross commented 8 years ago

FEWD Week #1 Project: HTML/CSS Basics

Description

For the first assignment, you will begin creating the beginnings of your first website. Take what you've learned from class and build a portfolio site that showcases all of the projects you'll be completing over the next few weeks. Build two pages - an 'About Page' and a 'Portfolio' - that link to one another. Your 'About Page' should describe your mission and value proposition and your 'Portfolio' should include descriptions of the work you [will] do for Relaxr, Startup Matchmaker, and CitiPix.

Student: Mary Chao

Project URL: https://github.com/mareyc/homework-portfolio

Technical Requirements Does Not Meet Expectations (0) Meets Expectations (1) Exceeds Expectations (2)
Link both pages together using a tag x
Use a unique title and a single unique h1 tag x
Show images using img tags including unique alt attributes x
Use an external CSS stylesheet to style your pages x
Select at least 5 elements on the page and apply at least 5 different css properties (font-size, color, font-family, background, text-decoration) to these elements x
Use at least 6 different HTML tags (h1, h2, h3, h4, h5, h6, p, ul, ol, a, img) on your pages x
Follow naming conventions, maintain consistency across your .html and .css files x
Indent nested elements to increase your code's readability x
TOTAL: 14/16
barryross commented 8 years ago

Hey Mary,

Great work on this first assignment!

To clarify, I left a mark off of the image requirement because I didn't see any alt tags. Please take a look at this for more info and do your best to include them next time http://www.w3schools.com/tags/att_img_alt.asp

Also, I left another off because although you did a great job styling elements in your .css file, the assignment does ask you to style at least 5 different elements.

Please have a look at the inline comments in your commits for more more detailed responses from me! Again, great stuff!