Code broken with the latest commits

sarperdag commented 10 years ago

Hello,

We're using ImageMagick for a magic wand operation in our code. Everything was working fine until the latest cocoapods version but then, after the commit that added support for i386 architecture, things broke.

Here is our code:

PixelIterator* iterator = NULL;
PixelWand** pixels = NULL;
size_t x;
iterator = NewPixelRegionIterator(magick_wand, _touchCoords.x*scale, _touchCoords.y*scale, 1, 1);
pixels = PixelGetNextIteratorRow(iterator,&x);
bc_wand = pixels[0];

Here, iterator always comes up NULL, any ideas why this might be happening?

sarperdag commented 10 years ago

Just realized this works on simulator but not on actual device...

marforic commented 10 years ago

I'll test it!

~C

On Thursday, May 1, 2014, Sarp Erdag notifications@github.com wrote:

Just realized this works on simulator but not on actual device...

— Reply to this email directly or view it on GitHubhttps://github.com/marforic/imagemagick_lib_iphone/issues/10#issuecomment-41924406 .

System Security Group ETH Zurich CNB F 100.5 Universitätsstrasse 6 8092 Zurich SWITZERLAND

Phone: +41 44 633 76 99 E-Mail: maclaudi@inf.ethz.ch Web: http://www.syssec.ethz.ch/people/maclaudi

marforic commented 10 years ago

Please, can you give me a minimal running code?

(also, I just pushed a change, make sure you get the latest commit from github) Thanks,

~C

sarperdag commented 10 years ago

Is the latest commit also reflected to cocoapods?

marforic commented 10 years ago

I don't know how those work...

~C

On Tuesday, May 6, 2014, Sarp Erdag notifications@github.com wrote:

Is the latest commit also reflected to cocoapods?

— Reply to this email directly or view it on GitHubhttps://github.com/marforic/imagemagick_lib_iphone/issues/10#issuecomment-42337344 .

System Security Group ETH Zurich CNB F 100.5 Universitätsstrasse 6 8092 Zurich SWITZERLAND

Phone: +41 44 633 76 99 E-Mail: maclaudi@inf.ethz.ch Web: http://www.syssec.ethz.ch/people/maclaudi

sarperdag commented 10 years ago

Cocoapods points to http://www.imagemagick.org/download/iOS/

You suggest we integrate manually and not use cocoapods?

marforic commented 10 years ago

I've uploaded the new compiled libraries there, as well.

~C

On Tuesday, May 6, 2014, Sarp Erdag notifications@github.com wrote:

Cocoapods points to http://www.imagemagick.org/download/iOS/

You suggest we integrate manually and not use cocoapods?

— Reply to this email directly or view it on GitHubhttps://github.com/marforic/imagemagick_lib_iphone/issues/10#issuecomment-42337882 .

System Security Group ETH Zurich CNB F 100.5 Universitätsstrasse 6 8092 Zurich SWITZERLAND

Phone: +41 44 633 76 99 E-Mail: maclaudi@inf.ethz.ch Web: http://www.syssec.ethz.ch/people/maclaudi

sarperdag commented 10 years ago

It still shows 24 april as the latest date?! Anyways here is the sample project causing the problem. It works on the simulator but doesn't work on device.

https://s3.amazonaws.com/uploads.hipchat.com/66760/490223/EDC9ZaSOwIwf2pV/magicWandCleanse.zip

marforic commented 10 years ago

Hi, It works for me replacing the libraries. I'm packing it up and sending it to you.

~C

sarperdag commented 10 years ago

@marforic Thanks but not received anything yet?

marforic commented 10 years ago

I've sent it to you by e-mail...

~C

On 7 May 2014 09:42, Sarp Erdag notifications@github.com wrote:

@marforic https://github.com/marforic Thanks but not received anything yet?

— Reply to this email directly or view it on GitHubhttps://github.com/marforic/imagemagick_lib_iphone/issues/10#issuecomment-42398096 .

System Security Group ETH Zurich CNB F 100.5 Universitätsstrasse 6 8092 Zurich SWITZERLAND

Phone: +41 44 633 76 99 E-Mail: maclaudi@inf.ethz.ch Web: http://www.syssec.ethz.ch/people/maclaudi

sarperdag commented 10 years ago

Strange, didn't get anything, can you please send again? Thanks a lot!

marforic commented 10 years ago

I'll just send it here:

Tested on an iPhone 5 (armv7s).

Don't know when the pod will get the latest ImageMagick, I just plugged in the one I just compiled.

https://dl.dropboxusercontent.com/u/3126629/magicWandCleanse.zip

Let me know when you get it and if it works!

Best,

~C

On 7 May 2014 09:54, Sarp Erdag notifications@github.com wrote:

Strange, didn't get anything, can you please send again? Thanks a lot!

— Reply to this email directly or view it on GitHubhttps://github.com/marforic/imagemagick_lib_iphone/issues/10#issuecomment-42398945 .

System Security Group ETH Zurich CNB F 100.5 Universitätsstrasse 6 8092 Zurich SWITZERLAND

Phone: +41 44 633 76 99 E-Mail: maclaudi@inf.ethz.ch Web: http://www.syssec.ethz.ch/people/maclaudi

sarperdag commented 10 years ago

Thanks it works!

marforic / imagemagick_lib_iphone

Code broken with the latest commits #10