search

margaritahumanitarian / helpafamily

Impactful ways to help families in need through donated meals, hygiene kits, and more. By Margarita Humanitarian Foundation.
https://helpafamily.margaritahumanitarian.org/
GNU Affero General Public License v3.0
67 stars 111 forks source link

🧪 ✨ Let's Get Code Coverage to 80% ✨ #367

Open LowLifeArcade opened 2 years ago

LowLifeArcade commented 2 years ago

What should we change and why?

Thank you @idiglove 🙏 for adding test coverage to the Card component. We could use more! If you want to contribute to getting the code base test coverage to 80%, please join in 🦖

Check out #354 for an example.

FranciscoBastos commented 2 years ago

Hi,

My colleague Ana Rita and I are students at masters in software engineering at FEUP (https://paginas.fe.up.pt/~estudar/mesw/). As part of evaluating one of the curriculum units, we need to choose an open-source project and fix an issue. We would like to know if we could help with this issue?

LowLifeArcade commented 2 years ago

Hi @FranciscoBastos. Yes, absolutely! You and Ana can choose a component (or other parts of the codebase) and go from there with your testing! Try to keep your PRs limited to one piece of code or a single component. And have fun!

FranciscoBastos commented 2 years ago

Hi, @LowLifeArcade, could you assign me to the issue then? @RitaVeiga and I would like to take this issue!

LowLifeArcade commented 2 years ago

You got it @FranciscoBastos!

FranciscoBastos commented 2 years ago

Hi @LowLifeArcade me, and @RitaVeiga are getting the following error when running the tests, do you know how can we fix it? Captura de ecrã 2022-05-10, às 7 08 21 PM

FranciscoBastos commented 2 years ago

Hi, @LowLifeArcade @RitaVeiga and I have already been able to run the tests, and we have also written some test scripts. They are selenium test scripts that test the front-end of the application. They consist of E2E integration testing, and I think it was a reasonable effort on a first approach. We will keep updating the test suit so you can reach 80% of coverage!