margau / dmxnet

ArtNet-DMX-sender and receiver for nodejs
MIT License
69 stars 22 forks source link

Give the `dmxnet` constructor a default value #38

Closed soimon closed 3 years ago

soimon commented 3 years ago

According to the TypeScript definitions, you should be able to call new dmxnet() without providing an option object. Right now though, leaving this parameter empty throws TypeError: Cannot read property 'oem' of undefined. This pull request adds a default value to the constructor of dmxnet so that it behaves according to the documentation.

margau commented 3 years ago

Thanks for the PR!