Points to old/wrong namespace [Android]

margelo / react-native-bignumber

🔢 The fastest Big Number library for React Native

https://margelo.io

MIT License

342 stars 12 forks source link

Points to old/wrong namespace [Android] #53

Closed Kida007 closed 2 years ago

Kida007 commented 2 years ago

Android throws an runtime Error while loading the C++ library :

Didn't find class "com.reactnative bignumber.BigNumber Module"

I see we recently changed the namespace to com.margelo.bignumber . maybe something was missed ( just an assumption). Open to propose a fix creating a PR but need some initial pointers 😅

PS : thanks for the amazing libraries and OSS work . Team Margelo 💙

mrousavy commented 2 years ago

Uhm, whoops? Can you submit a PR that fixes this naming issue?

Kida007 commented 2 years ago

Hey @mrousavy sorry i almost forgot about it. but looks like it was fixed. thanks for the amazing work. much appreciated.