Closed kantorm closed 10 months ago
huh, that's weird. Is that something that's not covered by a BN.js test? We'll take a look....
Hi @mrousavy , is there any progress on that issue? I'd like to use this library, but i want to be sure that there are no potentially costly bugs
any news ?
we'll take a look
Hey! I started working on the issue. Seems like problem with umod indeed. However, I need to take a closer looks as Q.x looks to be a red number. I'm not sure what umod in a field would mean to be honest :D Will do my best to resolve it this week.
Same issue. Trying to use tronweb.fromMnemonic
(uses elliptic under the hood).
Sorry guys! I was super busy in December and completely forgot about the issue. I found the issue and opened a pr with the fix.
I'm trying to use this package in a project which uses
elliptic
and one of the functions produce different output when using react-native-bignumber and bn.js. I managed to identify piece of code that returns different output. I tested it in the example app of react-native-bignumber. The code looks pretty much like this.It looks like there are some differences in
umod
implementation but I might be wrong.